codecov-io commented on issue #111: ACL enhancement. URL: https://github.com/apache/kylin/pull/111#issuecomment-370668481 # [Codecov](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=h1) Report > Merging [#111](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/1e7825bd8b69ad7517298175d2d5bb0fde578fca?src=pr&el=desc) will **decrease** coverage by `0.05%`. > The diff coverage is `0.58%`. [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/111/graphs/tree.svg?token=JawVgbgsVo&src=pr&height=150&width=650)](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #111 +/- ## =========================================== - Coverage 21.66% 21.6% -0.06% - Complexity 3857 3859 +2 =========================================== Files 992 996 +4 Lines 59797 59964 +167 Branches 8653 8661 +8 =========================================== + Hits 12954 12956 +2 - Misses 45645 45811 +166 + Partials 1198 1197 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=tree) | Coverage ? | Complexity ? | | |---|---|---|---| | [...apache/kylin/common/persistence/ResourceStore.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9SZXNvdXJjZVN0b3JlLmphdmE=) | `59% <?> (?)` | `25 <0> (?)` | :arrow_down: | | [...a/org/apache/kylin/rest/request/AccessRequest.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvcmVxdWVzdC9BY2Nlc3NSZXF1ZXN0LmphdmE=) | `100% <?> (?)` | `9 <0> (?)` | :arrow_down: | | [...pache/kylin/rest/security/springacl/AclRecord.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VjdXJpdHkvc3ByaW5nYWNsL0FjbFJlY29yZC5qYXZh) | `0% <0%> (?)` | `0 <0> (?)` | | | [...ache/kylin/rest/controller/TableACLController.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9UYWJsZUFDTENvbnRyb2xsZXIuamF2YQ==) | `0% <0%> (?)` | `0 <0> (?)` | | | [...va/org/apache/kylin/rest/security/ManagedUser.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VjdXJpdHkvTWFuYWdlZFVzZXIuamF2YQ==) | `0% <0%> (?)` | `0 <0> (?)` | :arrow_down: | | [...ylin/rest/security/springacl/MutableAclRecord.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VjdXJpdHkvc3ByaW5nYWNsL011dGFibGVBY2xSZWNvcmQuamF2YQ==) | `0% <0%> (?)` | `0 <0> (?)` | | | [...pache/kylin/common/persistence/JsonSerializer.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9Kc29uU2VyaWFsaXplci5qYXZh) | `0% <0%> (?)` | `0 <0> (?)` | :arrow_down: | | [.../java/org/apache/kylin/rest/util/ValidateUtil.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9WYWxpZGF0ZVV0aWwuamF2YQ==) | `3.07% <0%> (-0.1%)` | `3 <0> (?)` | | | [.../apache/kylin/rest/security/springacl/AceImpl.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VjdXJpdHkvc3ByaW5nYWNsL0FjZUltcGwuamF2YQ==) | `0% <0%> (?)` | `0 <0> (?)` | | | [.../apache/kylin/rest/security/springacl/SidInfo.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VjdXJpdHkvc3ByaW5nYWNsL1NpZEluZm8uamF2YQ==) | `0% <0%> (?)` | `0 <0> (?)` | | | ... and [20 more](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute <relative> (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=footer). Last update [1e7825b...fb633e4](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services