liyang-gmt8 closed pull request #114: KYLIN-3287, fix when a shard by column is
in dict encoding, dict buil?
URL: https://github.com/apache/kylin/pull/114
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CreateDictionaryJob.java
b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CreateDictionaryJob.java
index a4576774aa..dab4880390 100644
---
a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CreateDictionaryJob.java
+++
b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CreateDictionaryJob.java
@@ -82,7 +82,7 @@ public IReadableTable getDistinctValuesFor(TblColRef col) {
List<TblColRef> uhcColumns =
cube.getDescriptor().getAllUHCColumns();
Path colDir;
- if (uhcColumns.contains(col)) {
+ if (config.isBuildUHCDictWithMREnabled() &&
uhcColumns.contains(col)) {
colDir = new Path(dictPath, col.getIdentity());
} else {
colDir = new Path(factColumnsInputPath, col.getIdentity());
diff --git
a/examples/test_case_data/localmeta/cube_desc/ci_inner_join_cube.json
b/examples/test_case_data/localmeta/cube_desc/ci_inner_join_cube.json
index 809e188ee3..ec1100a1da 100644
--- a/examples/test_case_data/localmeta/cube_desc/ci_inner_join_cube.json
+++ b/examples/test_case_data/localmeta/cube_desc/ci_inner_join_cube.json
@@ -342,7 +342,8 @@
},
{
"column": "TEST_KYLIN_FACT.LEAF_CATEG_ID",
- "encoding": "dict"
+ "encoding": "dict",
+ "isShardBy" : true
},
{
"column": "TEST_CATEGORY_GROUPINGS.META_CATEG_NAME",
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
