rogercloud commented on a change in pull request #135: KYLIN-3347 : calcite
function QueryService Exception
URL: https://github.com/apache/kylin/pull/135#discussion_r184280761
##########
File path:
query/src/main/java/org/apache/kylin/query/util/DefaultQueryTransformer.java
##########
@@ -50,6 +50,8 @@
private static final Pattern PIN_SUM_OF_FN_CONVERT = Pattern
.compile(S0 + "SUM" + S0 + "\\(" + S0 + "\\{\\s*fn" + SM +
"convert" + S0 + "\\(" + S0 + "([^\\s,]+)" + S0
+ "," + S0 + "SQL_DOUBLE" + S0 + "\\)" + S0 + "\\}" + S0 +
"\\)", Pattern.CASE_INSENSITIVE);
+ private static final Pattern PTN_HAVING_FUNCTION = Pattern.compile("\\{fn"
+ "(.*?)" + "\\}",
Review comment:
If TIMESTAMPADD and SQL_TSI_HOUR are also included, it should be added as
separated patterns by following the current design. Maybe the design is not the
best, but follow it can avoid unexpected issues. Unless you can tell why the
"general" matcher is better.
Kylin can support calcite reserved functions, and it's welcome to contribute
this part.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
