codecov-io commented on issue #139: Kylin 3221 Some improvements for lookup table URL: https://github.com/apache/kylin/pull/139#issuecomment-387961787 # [Codecov](https://codecov.io/gh/apache/kylin/pull/139?src=pr&el=h1) Report > Merging [#139](https://codecov.io/gh/apache/kylin/pull/139?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7217d7f9d28bdd7de56090189fbd5246a18cbf32?src=pr&el=desc) will **increase** coverage by `0.23%`. > The diff coverage is `30.25%`. [](https://codecov.io/gh/apache/kylin/pull/139?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #139 +/- ## =========================================== + Coverage 21.86% 22.1% +0.23% - Complexity 3879 3994 +115 =========================================== Files 985 1012 +27 Lines 59639 61081 +1442 Branches 8608 8754 +146 =========================================== + Hits 13041 13502 +461 - Misses 45396 46351 +955 - Partials 1202 1228 +26 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/139?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...apache/kylin/common/persistence/ResourceStore.java](https://codecov.io/gh/apache/kylin/pull/139/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9SZXNvdXJjZVN0b3JlLmphdmE=) | `59% <ø> (ø)` | `25 <0> (ø)` | :arrow_down: | | [...in/metadata/realization/IRealizationConstants.java](https://codecov.io/gh/apache/kylin/pull/139/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvcmVhbGl6YXRpb24vSVJlYWxpemF0aW9uQ29uc3RhbnRzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ain/java/org/apache/kylin/engine/mr/CubingJob.java](https://codecov.io/gh/apache/kylin/pull/139/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvQ3ViaW5nSm9iLmphdmE=) | `1.91% <ø> (+0.13%)` | `2 <0> (ø)` | :arrow_down: | | [.../org/apache/kylin/dict/lookup/SnapshotManager.java](https://codecov.io/gh/apache/kylin/pull/139/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9TbmFwc2hvdE1hbmFnZXIuamF2YQ==) | `19.14% <0%> (-1.79%)` | `7 <0> (ø)` | | | [...c/main/java/org/apache/kylin/engine/mr/MRUtil.java](https://codecov.io/gh/apache/kylin/pull/139/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvTVJVdGlsLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/139/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `14.77% <0%> (-0.1%)` | `35 <0> (ø)` | | | [...mr/steps/lookup/LookupSnapshotToMetaStoreStep.java](https://codecov.io/gh/apache/kylin/pull/139/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvbG9va3VwL0xvb2t1cFNuYXBzaG90VG9NZXRhU3RvcmVTdGVwLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...ache/kylin/engine/mr/LookupSnapshotJobBuilder.java](https://codecov.io/gh/apache/kylin/pull/139/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvTG9va3VwU25hcHNob3RKb2JCdWlsZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...ylin/storage/hbase/lookup/HBaseLookupProvider.java](https://codecov.io/gh/apache/kylin/pull/139/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9sb29rdXAvSEJhc2VMb29rdXBQcm92aWRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...org/apache/kylin/common/restclient/RestClient.java](https://codecov.io/gh/apache/kylin/pull/139/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9yZXN0Y2xpZW50L1Jlc3RDbGllbnQuamF2YQ==) | `13.93% <0%> (-1.05%)` | `3 <0> (ø)` | | | ... and [81 more](https://codecov.io/gh/apache/kylin/pull/139/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/139?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/139?src=pr&el=footer). Last update [7217d7f...f615dd1](https://codecov.io/gh/apache/kylin/pull/139?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
