shaofengshi commented on a change in pull request #147: KYLIN-3161 Enforce
global dictionary for bitmap count distinct column…
URL: https://github.com/apache/kylin/pull/147#discussion_r192590806
##########
File path:
core-cube/src/main/java/org/apache/kylin/cube/model/validation/rule/DictionaryRule.java
##########
@@ -89,17 +100,32 @@ public void validate(CubeDesc cubeDesc, ValidateContext
context) {
return;
}
+ if (StringUtils.isNotEmpty(builderClass) &&
!builderClass.equalsIgnoreCase(GlobalDictionaryBuilder.class.getName()) &&
bitmapMeasures.containsKey(dictCol) &&
!dictCol.getColumnDesc().getType().isIntegerFamily()){
Review comment:
"builderClass" can be empty, which would means the normal dictionary. So
this case should also be checked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
