shaofengshi closed pull request #152: KYLIN-3398 Fix inaccurate arithmetic
operations
URL: https://github.com/apache/kylin/pull/152
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/LookupTableToHFileJob.java
b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/LookupTableToHFileJob.java
index 39ebe996a6..054e1466b6 100644
---
a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/LookupTableToHFileJob.java
+++
b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/LookupTableToHFileJob.java
@@ -233,8 +233,8 @@ private void
removeSnapshotIfExist(ExtTableSnapshotInfoManager extSnapshotInfoMa
}
private int calculateShardNum(KylinConfig kylinConfig, long dataSize) {
- long shardSize = kylinConfig.getExtTableSnapshotShardingMB() * 1024 *
1024;
- return dataSize < shardSize ? 1 : (int) (Math.ceil(dataSize /
shardSize));
+ long shardSize = (long) (kylinConfig.getExtTableSnapshotShardingMB())
* 1024 * 1024;
+ return dataSize < shardSize ? 1 : (int) (Math.ceil((double) dataSize /
shardSize));
}
private byte[][] getSplitsByShardNum(int shardNum) {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
