shaofengshi commented on a change in pull request #174: KYLIN-3418 adjust
hybrid API
URL: https://github.com/apache/kylin/pull/174#discussion_r204966171
##########
File path:
server-base/src/main/java/org/apache/kylin/rest/service/HybridService.java
##########
@@ -43,8 +44,7 @@
@Autowired
private AclEvaluate aclEvaluate;
- public HybridInstance createHybridCube(String hybridName, String
projectName, String modelName,
- String[] cubeNames) {
+ public HybridRespone createHybridCube(String hybridName, String
projectName, String modelName, String[] cubeNames) {
Review comment:
"HybridRespone" is from the rest layer, it shouldn't be referenced at the
service layer. Here the interface should be "HybridInstance"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
