shaofengshi closed pull request #186: KYLIN-3479 Model can save when kafka
partition date column not select
URL: https://github.com/apache/kylin/pull/186
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/server-base/src/main/java/org/apache/kylin/rest/service/ModelService.java
b/server-base/src/main/java/org/apache/kylin/rest/service/ModelService.java
index 23c0085f21..b3f6e2d4dd 100644
--- a/server-base/src/main/java/org/apache/kylin/rest/service/ModelService.java
+++ b/server-base/src/main/java/org/apache/kylin/rest/service/ModelService.java
@@ -33,6 +33,7 @@
import org.apache.kylin.metadata.ModifiedOrder;
import org.apache.kylin.metadata.draft.Draft;
import org.apache.kylin.metadata.model.DataModelDesc;
+import org.apache.kylin.metadata.model.ISourceAware;
import org.apache.kylin.metadata.model.JoinsTree;
import org.apache.kylin.metadata.model.ModelDimensionDesc;
import org.apache.kylin.metadata.model.TableDesc;
@@ -132,6 +133,13 @@ public DataModelDesc createModelDesc(String projectName,
DataModelDesc desc) thr
throw new
BadRequestException(String.format(msg.getDUPLICATE_MODEL_NAME(),
desc.getName()));
}
+ String factTableName = desc.getRootFactTableName();
+ TableDesc tableDesc = getTableManager().getTableDesc(factTableName,
projectName);
+ if (tableDesc.getSourceType() == ISourceAware.ID_STREAMING
+ && (desc.getPartitionDesc() == null ||
desc.getPartitionDesc().getPartitionDateColumn() == null)) {
+ throw new IllegalArgumentException("Must define a partition
column.");
+ }
+
DataModelDesc createdDesc = null;
String owner =
SecurityContextHolder.getContext().getAuthentication().getName();
createdDesc = getDataModelManager().createDataModelDesc(desc,
projectName, owner);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
