momoxixi commented on issue #198: KYLIN-3499 Update HBaseResourceStore.java URL: https://github.com/apache/kylin/pull/198#issuecomment-415633716 Hi shaofengshi, You get my point, and here is my opinion for two comments,: 1. I consider Embedded `try-catch` is a compromise plan, or it would modify more code. 2. `IOException` maybe a more smarter choice, but after reading hbase source code `RetriesExhaustedException` is the one exception that need to recheck.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
