shaofengshi commented on a change in pull request #258: KYLIN-3356 Constant in
SecretKeySpec
URL: https://github.com/apache/kylin/pull/258#discussion_r220523698
##########
File path:
core-common/src/main/java/org/apache/kylin/common/util/EncryptUtil.java
##########
@@ -28,8 +30,10 @@
/**
* thisIsAsecretKey
*/
- private static byte[] key = { 0x74, 0x68, 0x69, 0x73, 0x49, 0x73, 0x41,
0x53, 0x65, 0x63, 0x72, 0x65, 0x74, 0x4b,
- 0x65, 0x79 };
+ private static byte[] key = new byte[16];
+ {
Review comment:
This block won't be executed. Please fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
