shaofengshi commented on a change in pull request #271: KYLIN-3603 Close the
HBase connection after used in UpdateHTableHostCLI
URL: https://github.com/apache/kylin/pull/271#discussion_r221411226
##########
File path:
storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/UpdateHTableHostCLI.java
##########
@@ -59,9 +59,10 @@
public UpdateHTableHostCLI(List<String> htables, String oldHostValue)
throws IOException {
this.htables = htables;
this.oldHostValue = oldHostValue;
- Connection conn =
ConnectionFactory.createConnection(HBaseConfiguration.create());
- hbaseAdmin = conn.getAdmin();
- this.kylinConfig = KylinConfig.getInstanceFromEnv();
+ try(Connection conn =
ConnectionFactory.createConnection(HBaseConfiguration.create());){
Review comment:
Please check the code format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
