It turns out that, BitSet.nextSetBit(int) is time-consuming, just replace it with a int[] will improve performance significantly.
Best Regard Zhou QianHao On 4/20/15, 4:38 PM, "hongbin ma" <[email protected]> wrote: >It's an existing optimization by @liyang, as i remember. Please justify it >before you change the code > >On Mon, Apr 20, 2015 at 4:35 PM, ZhouQianhao (JIRA) <[email protected]> >wrote: > >> ZhouQianhao created KYLIN-708: >> --------------------------------- >> >> Summary: replace BitSet for AggrKey >> Key: KYLIN-708 >> URL: https://issues.apache.org/jira/browse/KYLIN-708 >> Project: Kylin >> Issue Type: Improvement >> Components: Storage - HBase >> Reporter: ZhouQianhao >> Assignee: liyang >> >> >> inside endpoint, in order to get hashCode and compareTo, we use BitSet >>to >> store all the column that need to be calculated which is quite >>inefficient. >> >> >> >> -- >> This message was sent by Atlassian JIRA >> (v6.3.4#6332) >> > > > >-- >Regards, > >*Bin Mahone | 马洪宾* >Apache Kylin: http://kylin.io >Github: https://github.com/binmahone
