[ 
https://issues.apache.org/jira/browse/KYLIN-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555197#comment-14555197
 ] 

Julian Hyde commented on KYLIN-611:
-----------------------------------

By "implicit join", do you mean commas in the FROM clause? Mondrian can 
generate ANSI join syntax if it knows that the database can support them. We 
added that feature for Impala, since Impala isn't good at figuring out join 
order. See Mondrian's ImpalaDialect.

"Implicit joins" are still a useful feature, but I wouldn't put them in just 
for Mondrian's sake.

> Allow Implicit Joins
> --------------------
>
>                 Key: KYLIN-611
>                 URL: https://issues.apache.org/jira/browse/KYLIN-611
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Query Engine
>    Affects Versions: v0.7.1
>            Reporter: Sébastien Jelsch
>            Assignee: liyang
>             Fix For: v0.7.2
>
>         Attachments: implicit-join-exception.txt
>
>
> Allowing Implicit Joins would be a great improvement since tools like 
> Mondrian use this exclusively.
> Trying to execute this SQL Statement
> {code:sql}
> SELECT *
> FROM sales, products
> WHERE sales.product_id = products.id
> {code}
> results in the following error:
> {noformat}
> [ERROR][com.kylinolap.rest.controller.QueryController.doQuery(QueryController.java:227)]
>  - Exception when execute sql
> java.sql.SQLException: error while executing SQL "SELECT * FROM sales, 
> products WHERE sales.product_id = products.id LIMIT 50000": 
> org.eigenbase.rex.RexLiteral cannot be cast to org.eigenbase.rex.RexCall
> {noformat}
> See attachment for full exception details.
> The error is caused by OLAPJoinRel.implementOLAP(OLAPImplementor implementor):
> {code:java}
> RexCall condition = (RexCall) this.getCondition();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to