[ 
https://issues.apache.org/jira/browse/KYLIN-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645357#comment-14645357
 ] 

hongbin ma commented on KYLIN-914:
----------------------------------

hi dayue,

I reviewed the patch, it's okay. thanks for contributing!
before I apply you patch, can you regenerate your patch by:

git format-patch <commit_id> --stdout > <JIRA_NUMBER>.patch

this will assemble your name into the patch, and make a Kylin contributor:)

> Scripts shebang should use /bin/bash
> ------------------------------------
>
>                 Key: KYLIN-914
>                 URL: https://issues.apache.org/jira/browse/KYLIN-914
>             Project: Kylin
>          Issue Type: Bug
>          Components: General
>    Affects Versions: v0.7.2, v0.7.1
>            Reporter: Dayue Gao
>            Priority: Minor
>         Attachments: KYLIN-914.1.patch
>
>
> On my ubuntu machine, running "./bin/kylin.sh start" will give the following 
> error:
> {noformat}
> ./bin/kylin.sh: 20: [: unexpected operator
> ./bin/kylin.sh: 78: [: ==: unexpected operator
> usage: kylin.sh start or kylin.sh stop
> {noformat}
> This is due to kylin's scripts use "#!/bin/sh", however ubuntu symlinks 
> /bin/sh to dash, which is not compatible with bash.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to