[ 
https://issues.apache.org/jira/browse/KYLIN-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645389#comment-14645389
 ] 

hongbin ma commented on KYLIN-915:
----------------------------------

I suggest using interactive choosing here, to make sure correct upgration

> appendDBName in CubeMetadataUpgrade will return null
> ----------------------------------------------------
>
>                 Key: KYLIN-915
>                 URL: https://issues.apache.org/jira/browse/KYLIN-915
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: hongbin ma
>            Assignee: Shaofeng SHI
>
> In current implementation, appendDBName will return null if more than one 
> tables share the table name. The caller is not aware of this, and will put 
> null values into project/cube instance, this will cause runtime errors.
>   if (count == 1)
>             return result;
>         if (count > 1) {
>             errorMsgs.add("There are more than 1 table named with '" + table 
> + "' in different database; The program couldn't determine, randomly pick '" 
> + result + "'");
>         }
>         if (count == 0) {
>             errorMsgs.add("There is no table named with '" + table + "'");
>         }
>         return result;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to