Hi, Sorry for the un-formatted patch, I have uploaded new patches for branch-0.7-staging and branch-0.8.
I’m not so familar about git patching, so let me know if there’s any mistake, I will correct it ASAP. Best Regards, Yerui Sun [email protected] > 在 2015年8月4日，17:38，周千昊 <[email protected]> 写道： > > Hi, Sun > thank you for your patch, however I am not able to apply this patch > with your commit info(git am failed), will you please check again for this > patch? > Also there are 2 major branched (0.7-staging and 0.8), and there are > lots of changes between them and they will not be merged together, so would > you please create two patches for each one of them? > > sunyerui (JIRA) <[email protected]>于2015年8月4日周二 下午3:57写道： > >> >> [ >> https://issues.apache.org/jira/browse/KYLIN-923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >> ] >> >> sunyerui updated KYLIN-923: >> --------------------------- >> Attachment: KYLIN-923.patch >> >> Patch uploaded. >> Catch all Exception in FetchRunner.run() to avoid stopping running. >> Related tests also patched. >> >>> FetcherRunner will never run again if encountered exception during >> running >>> >> -------------------------------------------------------------------------- >>> >>> Key: KYLIN-923 >>> URL: https://issues.apache.org/jira/browse/KYLIN-923 >>> Project: Kylin >>> Issue Type: Bug >>> Components: Job Engine >>> Affects Versions: v0.7.2 >>> Reporter: sunyerui >>> Assignee: ZhouQianhao >>> Attachments: KYLIN-923.patch >>> >>> >>> {{FetcherRunner}} was scheduled at fix rate in {{fetcherPool}} which is >> a {{ScheduledExecutorService}}. In every running, {{FetcherRunner}} fetch >> all jobs from {{executableManager}}, and submit READY jobs to execute. >>> If exceptions encountered during running, such as >> {{executableManager.getAllJobIds()}} or >> {{executableManager.getAllJobIds()}}, the {{FetcherRunner}} will never run >> again in {{fetcherPool}}, that was explained in comment of >> {{ScheduledExecutorService.scheduleAtFixedRate}}. >>> The solution to resolve this issue is simple, that catch all >> {{Exception}} during {{FetcherRunner.run()}}. I will upload a patch later. >> >> >> >> -- >> This message was sent by Atlassian JIRA >> (v6.3.4#6332) >> > -- > Best Regard > ZhouQianhao
