thanks Hua! I have applied you patch in 0.7 staging, and cherry-picked it to 0.8 branch
On Fri, Aug 14, 2015 at 5:31 PM, Huang Hua (JIRA) <[email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/KYLIN-949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Huang Hua updated KYLIN-949: > ---------------------------- > Attachment: fix_kylin_949.patch > > Here is my patch to fix the bug, which basically adds hashcode() and > equals() implementations in PrepareSqlRequest. > > > Query cache doesn't work properly for prepareStatement queries > > -------------------------------------------------------------- > > > > Key: KYLIN-949 > > URL: https://issues.apache.org/jira/browse/KYLIN-949 > > Project: Kylin > > Issue Type: Bug > > Components: REST Service > > Affects Versions: v0.7.2, v0.7.1 > > Reporter: Huang Hua > > Assignee: Zhong,Jason > > Attachments: fix_kylin_949.patch > > > > > > There is a bug in searchQueryInCache() method, for PrepareSqlRequest, > the cache logic is wrong which returns the same result for any > PrepareSqlRequest with same sql no matter what the actual params are. > > For example, using "select LEAF_CATEG_ID from KYLIN_SALES where > LEAF_CATEG_ID = ? group by LEAF_CATEG_ID;" with params=[65] to fire > request, and kylin will return 65. Let's suppose that query is cached(we > can modify kylin settings to enable it to cache every query). > > And then using the same sql but with params=[130], which returns 65 > instead of 130. > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) > -- Regards, *Bin Mahone | 马洪宾* Apache Kylin: http://kylin.io Github: https://github.com/binmahone
