It is a good practice, should it be added this to the development guide?

hongbin ma <[email protected]>于2015年8月19日周三 下午1:32写道:

> hi,
>
> As we reviewed the code we found that Kylin left lots of garbage files in:
> 1. Local file system of the CLI
> 2. HDFS
> 3. Local file system of the hadoop nodes.
>
> A ticked was opened to track this issue:
> https://issues.apache.org/jira/browse/KYLIN-926
>
> For future developments, please:
> 1. Whenever you want to create temp files at Local, choose
> File.createTempFile or use the folder:
> BatchConstants.CFG_KYLIN_LOCAL_TEMP_DIR(/tmp/kylin), do not randomly use
> another folder in /tmp, it will end up a mess, and look unprofessional.
>
> 2. Whenever you create temp files at Local, remember to delete it after
> using it. It’s best to use FileUtils.forceDelete, as it also works for
> deleting folders. Try avoid deleteOnExit, in case Kylin exits abnormally.
>
> 3. Whenever you want to create files in HDFS, try to create it under
> kylin.hdfs.working.dir or BatchConstants.CFG_KYLIN_HDFS_TEMP_DIR, and
> remember to delete it after it is no longer useful. Try avoid throwing
> everything into hdfs:///tmp and leave it as garbage.
>
>
> --
> Regards,
>
> *Bin Mahone | 马洪宾*
> Apache Kylin: http://kylin.io
> Github: https://github.com/binmahone
>
-- 
Best Regard
ZhouQianhao

Reply via email to