Looks good, merge soon... Thanks, George!
On Fri, Aug 28, 2015 at 9:39 AM, Shi, Shaofeng <[email protected]> wrote: > George, very cool, we expect such contributions from community; @Jason, > could you review this patch and merge it into 0.7-staging? Thank you all! > > From: nichunen <[email protected]<mailto:[email protected]>> > Reply-To: "[email protected]<mailto: > [email protected]>" <[email protected]<mailto: > [email protected]>> > Date: Thursday, August 27, 2015 at 10:06 PM > To: dev <[email protected]<mailto: > [email protected]>> > Subject: Re: [jira] [Created] (KYLIN-966) When user creates a cube, if > enter a name which already exists, Kylin will thrown expection on last step > > Hi, > > I have attached a patch to fix the issue. > https://issues.apache.org/jira/browse/KYLIN-966 > > ________________________________ > Best Regards, > > George/倪春恩 > Software Engineer/软件工程师 > Mobile:+86-13501723787| Fax:+8610-56842040 > 北京明略软件系统有限公司(www<http://www.semidata.com/>.mininglamp.com) > 北京市昌平区东小口镇中东路398号中煤建设集团大厦1号楼4层 > F4,1#,Zhongmei Construction Group Plaza,398# Zhongdong Road,Changping > District,Beijing,102218 > > ---------------------------------------------------------------------------------------------------------------------------- > [cid:[email protected]] > > From: Shaofeng SHI (JIRA)<mailto:[email protected]> > Date: 2015-08-26 16:36 > To: dev<mailto:[email protected]> > Subject: [jira] [Created] (KYLIN-966) When user creates a cube, if enter a > name which already exists, Kylin will thrown expection on last step > Shaofeng SHI created KYLIN-966: > ---------------------------------- > > Summary: When user creates a cube, if enter a name which > already exists, Kylin will thrown expection on last step > Key: KYLIN-966 > URL: https://issues.apache.org/jira/browse/KYLIN-966 > Project: Kylin > Issue Type: Bug > Components: Web > Affects Versions: v0.7.2 > Reporter: Shaofeng SHI > Assignee: Zhong,Jason > > > Kylin cube wizard should check the uniqueness of the name once user > entered it; Otherwise, it will fail on last step when writting to resource > store (timestamp wasn' expected); And even if user changes name will not > work, finally have to cancel and create from scratch, which is bad. > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) >
