pan3793 commented on a change in pull request #809:
URL: https://github.com/apache/incubator-kyuubi/pull/809#discussion_r670259270
##########
File path: dev/merge_kyuubi_pr.py
##########
@@ -252,7 +252,7 @@ def main():
# Merged pull requests don't appear as merged in the GitHub API;
# Instead, they're closed by asfgit.
merge_commits = \
- [e for e in pr_events if e["event"] == "closed"]
+ [e for e in pr_events if e["event"] == "closed" and e["commit_id"]]
Review comment:
The differences between closed PR and merged PR by the script are:
```
// closed by click button
{
// ...
"event": "closed",
"commit_id": null
// ...
},
```
```
// merged by script
{
// ...
"event": "closed",
"commit_id": "622783b4d1e8e9a0b4738ace4bfc7eed951e1fab",
// ...
},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
