+1, I like this idea, it avoids the possibility of engine thrift class conflicts in different environments.
Kind Regards, Zhen Wang Cheng Pan <pan3...@gmail.com> 于2023年11月28日周二 01:00写道： > > Hi Kyuubi developers, > > Recently, I've been looking at the code of the Hive engine, one of my > goals id to make it support multiple versions of Hive runtime, > including > - 3.1.3, which is the latest stable version of Apache Hive, already supported > - 2.3.9, which is the latest stable version of Apache Hive 2.x, is > adopted widely, including Apache Spark, Apache Flink > - 2.1.1-cdh6.3.2, the latest free version of CDH, has lots of users > > When I tried to run the Hive engine built against Hive 3.x with Hive > 2.3.9/2.1.1-cdh6.3.2 runtime, I encountered some thrift class conflict > issues which were hard to resolve, thus I propose to create a > pre-shaded hive-service-rpc to tackles such issue. > > I have created two PRs[1][2] to demonstrate and verify my idea, it > also introduces additional benefits, e.g. speed up the engine > packaging by reducing relocation classes. > > Looking forward to the community feedback and PR reviews. > > Once the idea is accepted, and [1] gets merged, I will start the > kyuubi-shaded release voting. > > [1] https://github.com/apache/kyuubi-shaded/pull/20 > [2] https://github.com/apache/kyuubi/pull/5783 > > Thanks, > Cheng Pan
