Hi Javier, I was on vacation until last week, hence the long silence..
On Thursday, 2008-05-15 18:39:38 +0700, Javier SOLA wrote: > We are having an issue related to ICU. After 2.6, they changed the ZWSP > character (which we use as a word separator in Khmer) from being a > "spacing" character to be a "control" character, it was not changed for its > usage, but "not to confuse developers". A side effect of this is that > tokenization does not take into account ZWSP... and spell-checking for > Khmer no longer works in OOo. > > I remember that the patching of version 2.6 of ICU for versions OOo 2.1 and > earlier required patching the OOo ICU patch, is it still the same for the > present version? The overall process is still the same. However, patches to the patch file are nasty to handle if that changed in the meantime before the patch is applied in a CWS. Furthermore, we're trying to get rid of all ICU patches by filing them to the ICU bug tracker, so hopefully one day we will be able to build against a plain system-icu without losing functionality, see also http://wiki.services.openoffice.org/wiki/ICU/bugs_and_patches > If I remember well: > > - Download ICU 3.6 > - Apply the current icu-3.6.patch > - Make your changes > - Make a diff with 3.6 (call it patch1) > - Make a diff between de current icu-3.6.patch and patch1 -> send this patch > > Is this correct? This is one way, but the nasty one ;-) Preferred is a diff against the plain unpatched ICU that can be applied to a patched ICU and then the OOo ICU-patch file automatically be recreated by issuing a dmake create_patch command. But, isn't there another way to solve the spell-checking issue than patching ICU? Can't it be done in the breakiterator? That would be much preferred. Eike -- OOo/SO Calc core developer. Number formatter stricken i18n transpositionizer. SunSign 0x87F8D412 : 2F58 5236 DB02 F335 8304 7D6C 65C9 F9B5 87F8 D412 OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS Please don't send personal mail to the [EMAIL PROTECTED] account, which I use for mailing lists only and don't read from outside Sun. Use [EMAIL PROTECTED] Thanks.
pgp8MiNH85dqm.pgp
Description: PGP signature
