> On Aug. 19, 2015, 7:27 a.m., Amareshwari Sriramadasu wrote: > > lens-ui/package.json, line 12 > > <https://reviews.apache.org/r/37530/diff/2/?file=1041996#file1041996line12> > > > > How are these dependencies downloaded? > > > > Can you also update license of each of the dependency here for us to > > check with apache compatibility. > > Ankeet Maini wrote: > These dependencies are downloaded by npm (Node Package Manager). These > are the licenses which the app uses *(LICENSES: Apache, Apache-2.0, BSD, > BSD-3-Clause, BSD-3-Clause AND MIT, CC-BY, GPL, ISC, LGPL, MIT, MIT/X11, MPL, > Unknown, WTFPL)* > > Rajat Khandelwal wrote: > Which one is unknown? > > Also, I think earlier versions of lgpl are not compatible with apache. > Can you check wrt the actual version?
You can check http://www.apache.org/legal/resolved.html for compatability with apache license. With respect to the same, out of the licenses mentioned above Apache, Apache-2.0, BSD, BSD-3-Clause, BSD-3-Clause AND MIT, MIT, MIT/X11, ISC (licence is similar to BSD), The following can be included (Category-B), some of these might require a mention in NOTICE (if they are getting bundled) : CC-BY (See http://www.apache.org/legal/resolved.html#cc-sa), MPL, All versions of GPL and LGPL can not be included - see http://www.apache.org/legal/resolved.html#category-x. After going through attached licenses.txt, I see that the only dependency with GPL and LGPL license is : [email protected] [license(s): BSD-3-Clause, GPL, LGPL, MPL]. The package is with more than one license and BSD-3-Clause and MPL are accepted licenses. Verified the same at https://www.npmjs.com/package/tough-cookie and https://github.com/SalesforceEng/tough-cookie/blob/master/LICENSE. Not seeing any issue with dependency licenses. Ankeet Maini, Can you please attach the licenses.txt at https://cwiki.apache.org/confluence/display/LENS/Licensing+in+Apache+Lens. You can put a new section licensing with UI module and mention the same. If we are planning to provide a convienient binary distribution for UI, we need to add appropriate LICENSE and NOTICE files with respect to above licenses listed. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37530/#review95838 ----------------------------------------------------------- On Aug. 24, 2015, 6:45 p.m., Ankeet Maini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37530/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2015, 6:45 p.m.) > > > Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat > Khandelwal, sharad agarwal, and Yash Sharma. > > > Repository: lens > > > Description > ------- > > LENS-629 - A new improved web client > > > Diffs > ----- > > .gitignore d0fa424 > lens-ui/README.markdown PRE-CREATION > lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION > lens-ui/app/actions/LoginActions.js PRE-CREATION > lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION > lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION > lens-ui/app/adapters/BaseAdapter.js PRE-CREATION > lens-ui/app/app.js PRE-CREATION > lens-ui/app/components/AboutComponent.js PRE-CREATION > lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION > lens-ui/app/components/AppComponent.js PRE-CREATION > lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION > lens-ui/app/components/CubeTreeComponent.js PRE-CREATION > lens-ui/app/components/DatabaseComponent.js PRE-CREATION > lens-ui/app/components/HeaderComponent.js PRE-CREATION > lens-ui/app/components/LoaderComponent.js PRE-CREATION > lens-ui/app/components/LoginComponent.js PRE-CREATION > lens-ui/app/components/LogoutComponent.js PRE-CREATION > lens-ui/app/components/QueryBoxComponent.js PRE-CREATION > lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION > lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION > lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION > lens-ui/app/components/QueryResultsComponent.js PRE-CREATION > lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION > lens-ui/app/components/SidebarComponent.js PRE-CREATION > lens-ui/app/components/TableSchemaComponent.js PRE-CREATION > lens-ui/app/components/TableTreeComponent.js PRE-CREATION > lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION > lens-ui/app/constants/AppConstants.js PRE-CREATION > lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION > lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION > lens-ui/app/stores/CubeStore.js PRE-CREATION > lens-ui/app/stores/DatabaseStore.js PRE-CREATION > lens-ui/app/stores/TableStore.js PRE-CREATION > lens-ui/app/stores/UserStore.js PRE-CREATION > lens-ui/app/styles/css/global.css PRE-CREATION > lens-ui/app/styles/css/login.css PRE-CREATION > lens-ui/app/styles/css/query-component.css PRE-CREATION > lens-ui/app/styles/css/tree.css PRE-CREATION > lens-ui/app/styles/less/globals.less PRE-CREATION > lens-ui/config.json PRE-CREATION > lens-ui/index.html PRE-CREATION > lens-ui/package.json PRE-CREATION > lens-ui/server.js PRE-CREATION > lens-ui/webpack.config.js PRE-CREATION > > Diff: https://reviews.apache.org/r/37530/diff/ > > > Testing > ------- > > No server code added/modified. Just JavaScript! > > > File Attachments > ---------------- > > License details of NPM packages > > https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt > > > Thanks, > > Ankeet Maini > >
