[ 
https://issues.apache.org/jira/browse/LENS-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724823#comment-14724823
 ] 

Amareshwari Sriramadasu commented on LENS-629:
----------------------------------------------

[~ankeet.maini], Reviewed the patch and left some comments on the review board.

I still have few comments and questions on the changes :
# Checked all licences of dependencies being pulled. They look fine, updated 
the same on review board. Please update wiki as suggested, once the changes are 
merged.
# I see the build for UI is manual and which is documented in a read me. I 
think that wont help much for production environments, we might have to provide 
a proper package - a convenient distribution. Is there any plan for that? How 
are you deploying it on your end?
# The module is not mavenized, can we do it? sothat all other rat and 
checkstyle checks get applied. and also provide a build through maven, to make 
it easy.
#  What is the plan for test coverage? There are no unit tests added in the 
patch. Is it possible to put unit tests? Whats the plan for this module to be 
not broken with changes going in server.


> A new, improved web client.
> ---------------------------
>
>                 Key: LENS-629
>                 URL: https://issues.apache.org/jira/browse/LENS-629
>             Project: Apache Lens
>          Issue Type: Improvement
>            Reporter: Ankeet Maini
>            Assignee: Ankeet Maini
>              Labels: Hackathon-July
>         Attachments: Data discovery.png, autocomplete-1.png, 
> autocomplete-2.png, default-view.png, query results.png, query-status.png, 
> results.png
>
>
> A new web client app to fire queries, discover cubes, native tables and to 
> view results.
> Some of the salient features of the app would be:-
> 1. A single page app which is sleek, responsive and async.
> 2. Provision to discover cubes, tables in a tree view as well as in detail.
> 3. A scalable app which scales well for very large number of tables, cubes 
> and result sets to give an enriched experience without getting bloated or 
> introduce considerable lag during continuous use.
> 4. A book markable app where in URL reflects the state of the user, and is 
> easily sharable. e.g a link 
> [http://localhost:8080/query/schema/cube/sample_cube] 
> (http://localhost:8080/query/schema/cube/sample_cube) would open and give the 
> user the same view.
> 5. A syntax highlighted code editor.
> 6. Autocomplete for cubes, native tables to make the experience of writing 
> queries as close to SQL clients, bringing it on the browser.
> 7. Give a nice, clean and neat look to the data.
> 8. Provision to see queries based on the status, e.g. RUNNING, QUEUED, FAILED 
> etc.
> Tech stack
> 1. The app is built with ReactJS, Flux architecture from Facebook. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to