-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37648/
-----------------------------------------------------------
(Updated Sept. 3, 2015, 6:26 a.m.)
Review request for lens.
Changes
-------
Uploading patch for review. Changes include
1. Fix for null message in lensserver.log
2. Showing proper error message in lens-cli for explain queries.
One unit test is failing in lens-cli, I am debugging that.
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running TestSuite
Tests run: 20, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 117.264 sec
<<< FAILURE! - in TestSuite
testQueryCommands(org.apache.lens.cli.TestLensQueryCommands) Time elapsed:
71.898 sec <<< FAILURE!
org.glassfish.jersey.message.internal.MessageBodyProviderNotFoundException:
MessageBodyReader not found for media type=text/html; charset=ISO-8859-1,
type=class org.apache.lens.api.result.LensAPIResult, genericType=class
org.apache.lens.api.result.LensAPIResult.
at
org.glassfish.jersey.message.internal.ReaderInterceptorExecutor$TerminalReaderInterceptor.aroundReadFrom(ReaderInterceptorExecutor.java:207)
at
org.glassfish.jersey.message.internal.ReaderInterceptorExecutor.proceed(ReaderInterceptorExecutor.java:139)
at
org.glassfish.jersey.message.internal.MessageBodyFactory.readFrom(MessageBodyFactory.java:1109)
at
org.glassfish.jersey.message.internal.InboundMessageContext.readEntity(InboundMessageContext.java:851)
at
org.glassfish.jersey.message.internal.InboundMessageContext.readEntity(InboundMessageContext.java:785)
at
org.glassfish.jersey.client.InboundJaxrsResponse.readEntity(InboundJaxrsResponse.java:96)
at
org.glassfish.jersey.client.ScopedJaxrsResponse.access$001(ScopedJaxrsResponse.java:56)
at
org.glassfish.jersey.client.ScopedJaxrsResponse$1.call(ScopedJaxrsResponse.java:77)
at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
at org.glassfish.jersey.internal.Errors.process(Errors.java:228)
at
org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:397)
at
org.glassfish.jersey.client.ScopedJaxrsResponse.readEntity(ScopedJaxrsResponse.java:74)
at
org.apache.lens.client.LensStatement.explainQuery(LensStatement.java:372)
at org.apache.lens.client.LensClient.getQueryPlan(LensClient.java:211)
at
org.apache.lens.cli.commands.LensQueryCommands.explainQuery(LensQueryCommands.java:221)
at
org.apache.lens.cli.TestLensQueryCommands.testExplainFailQuery(TestLensQueryCommands.java:209)
at
org.apache.lens.cli.TestLensQueryCommands.testQueryCommands(TestLensQueryCommands.java:86)
Results :
Failed tests:
TestLensQueryCommands.testQueryCommands:86->testExplainFailQuery:209 ยป
MessageBodyProviderNotFound
Tests run: 20, Failures: 1, Errors: 0, Skipped: 0
Repository: lens
Description
-------
When two drivers give two different errors, it results in Internal server error
with LensMultiCauseException.It should compare both errors and give more
approriate one to end user. The error codes are organized in sequential order.
Error code with higher value is being thrown.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java 164195b
lens-api/src/main/resources/lens-errors.conf 3fb191e
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java
7a5b177
lens-client/src/main/java/org/apache/lens/client/LensClient.java afc76e5
lens-client/src/main/java/org/apache/lens/client/LensStatement.java 397bd82
lens-cube/src/main/java/org/apache/lens/cube/error/ColUnAvailableInTimeRangeException.java
dd3bb72
lens-cube/src/main/java/org/apache/lens/cube/error/FieldsCannotBeQueriedTogetherException.java
65b96d7
lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java
1fe74e2
lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java
9c0f936
lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java 98e38d5
lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java
4bd7cc8
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
69fbcc5
lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java
dfe0c32
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java
16429f0
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java
0dfd7da
lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java 486c6b3
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
3ef9652
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f
lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 826a59d
lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java
d8515d8
lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java 5444e71
lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java
fb1c89e
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java
9120a70
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
b34c217
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
ca07a0d
lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java
6150b14
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java
3c3aa9c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java
e5540d2
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
2083ef9
lens-driver-es/src/main/java/org/apache/lens/driver/es/exceptions/ESClientException.java
c2254f1
lens-driver-es/src/main/java/org/apache/lens/driver/es/exceptions/InvalidQueryException.java
8127cba
lens-server-api/src/main/java/org/apache/lens/server/api/LensErrorInfo.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java
c3ec099
lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java
603d7cb
lens-server-api/src/main/java/org/apache/lens/server/api/error/LensMultiCauseException.java
af9e33a
lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java
917eba3
lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java
366b306
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
c29a1ac
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java
6bfd77a
lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java
38b5ea0
lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java
64a75ce
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
2189eb8
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java
b3f5d93
Diff: https://reviews.apache.org/r/37648/diff/
Testing
-------
mvn clean install runs fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.212s]
[INFO] Lens .............................................. SUCCESS [3.014s]
[INFO] Lens API .......................................... SUCCESS [23.728s]
[INFO] Lens API for server and extensions ................ SUCCESS [18.542s]
[INFO] Lens Cube ......................................... SUCCESS [5:19.711s]
[INFO] Lens DB storage ................................... SUCCESS [20.030s]
[INFO] Lens Query Library ................................ SUCCESS [16.741s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:58.268s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [40.291s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [23.075s]
[INFO] Lens Server ....................................... SUCCESS [6:18.562s]
[INFO] Lens client ....................................... SUCCESS [39.919s]
[INFO] Lens CLI .......................................... SUCCESS [3:22.884s]
[INFO] Lens Examples ..................................... SUCCESS [10.586s]
[INFO] Lens Distribution ................................. SUCCESS [10.094s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:32.958s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.238s]
[INFO] Lens Regression ................................... SUCCESS [14.124s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 23:17.878s
[INFO] Finished at: Thu Aug 20 11:57:34 UTC 2015
[INFO] Final Memory: 171M/801M
[INFO] ------------------------------------------------------------------------
Thanks,
Sushil Mohanty
