----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37716/#review98814 -----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java (line 174) <https://reviews.apache.org/r/37716/#comment155412> Have text as "Position in queue" lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java (line 174) <https://reviews.apache.org/r/37716/#comment155413> Have text as "Position in queue" here as well. lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 811) <https://reviews.apache.org/r/37716/#comment155416> Should we set only if index returned is a valid index? Index may not be returned when it is in priority queue. And returning previos queue position would make sense in those cases. lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1013) <https://reviews.apache.org/r/37716/#comment155417> We need to check if any of the semantics change now, wrt this change. - Amareshwari Sriramadasu On Sept. 14, 2015, 4:57 a.m., Akshay Goyal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37716/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 4:57 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-753 > https://issues.apache.org/jira/browse/LENS-753 > > > Repository: lens > > > Description > ------- > > Queue number for queries in submitted queue > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 9614caa > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 44c0c62 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java > f78b7c3 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java > 6cecf7e > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > beaa72f > > lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ImmutableQueryCollection.java > 344ff10 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 23cc748 > > lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java > e3505bb > > lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java > f9e7701 > > lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java > cdbd2ad > > lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeQueryCollection.java > 7b43a38 > > lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java > 7a81e83 > > lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java > 51fcf00 > > Diff: https://reviews.apache.org/r/37716/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.847s] > [INFO] Lens .............................................. SUCCESS [2.853s] > [INFO] Lens API .......................................... SUCCESS [24.281s] > [INFO] Lens API for server and extensions ................ SUCCESS [21.248s] > [INFO] Lens Cube ......................................... SUCCESS [5:16.136s] > [INFO] Lens DB storage ................................... SUCCESS [19.132s] > [INFO] Lens Query Library ................................ SUCCESS [14.881s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:49.676s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [38.935s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.642s] > [INFO] Lens Server ....................................... SUCCESS [5:35.820s] > [INFO] Lens client ....................................... SUCCESS [36.048s] > [INFO] Lens CLI .......................................... SUCCESS [2:35.600s] > [INFO] Lens Examples ..................................... SUCCESS [8.941s] > [INFO] Lens Distribution ................................. SUCCESS [8.296s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:21.192s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.212s] > [INFO] Lens Regression ................................... SUCCESS [11.972s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 21:06.610s > [INFO] Finished at: Mon Aug 24 15:26:07 UTC 2015 > [INFO] Final Memory: 193M/1887M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Akshay Goyal > >
