-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38521/
-----------------------------------------------------------
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Bugs: LENS-607
https://issues.apache.org/jira/browse/LENS-607
Repository: lens
Description
-------
Iterators in java7 and java8 are returning elements in different order. All
most all failures are because of this case.
Changes:
TestBaseCubeQueries: Changed driver supported storages to single storage
instead of multiple
TestCubeRewriter: Returning diffrent orders in the joins. Separated join part
from the actaul query part and verified join part and remaining query part
separately.
TestStorageUtil: Multiple sets can answer the given partitions. Changed asserts
accordingly.
TestTimeRangeResolver: Changed asserts to cover all the errors.
*ColumnSQLRewriter* : Changed all data structures to *Linked* datastructures
(Arraylist --> LinkedList, HashSet to LinkedHashSet, HashMap to LinkedHashMap)
to return the elements in insertion order.
TestColumnSQLRewriter: Changed the order of columns in queries.
Diffs
-----
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 39441c9
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java
0f76c76
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
a58f5fe
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
bde4edd
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
493b8d6
lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java
81f515b
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java
cb27d50
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
295b476
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
db09a4b
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java
7be9793
pom.xml adba544
Diff: https://reviews.apache.org/r/38521/diff/
Testing
-------
Tested on both java7 and java8. Build is successful. Will post the build
artifact summary soon.
Thanks,
Raju Bairishetti
