----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38857/ -----------------------------------------------------------
(Updated Sept. 30, 2015, 11:30 a.m.) Review request for lens. Changes ------- Updated diff - 1. Reused Metastore client 2. Changed method name 3. Reverted back the exceptions thrown and handled invalidoperationexception. Repository: lens Description ------- Currently, To obtain list of native tables, CubeMetastoreService does the following - 1. Fetches the list of tables ( one MetastoreClient call) 2. Filters out the cube tables from the list. The filtering happens by looking at the table properties from the Table object. This table object is obtained with another Metastore call. So, If there are 'n' tables, there will be 'n' metastore calls. Instead of this, we can directly fetch the list of table objects for our list of table names in a single API call using getMetaStoreClient().getTableObjectsByName() method. Diffs (updated) ----- lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 37cebfe Diff: https://reviews.apache.org/r/38857/diff/ Testing ------- Yes. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.745 s] [INFO] Lens ............................................... SUCCESS [ 4.601 s] [INFO] Lens API ........................................... SUCCESS [ 31.397 s] [INFO] Lens API for server and extensions ................. SUCCESS [ 28.560 s] [INFO] Lens Cube .......................................... SUCCESS [07:04 min] [INFO] Lens DB storage .................................... SUCCESS [ 27.465 s] [INFO] Lens Query Library ................................. SUCCESS [ 23.361 s] [INFO] Lens Hive Driver ................................... SUCCESS [04:14 min] [INFO] Lens Driver for JDBC ............................... SUCCESS [ 50.792 s] [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 20.551 s] [INFO] Lens Server ........................................ SUCCESS [11:11 min] [INFO] Lens client ........................................ SUCCESS [ 48.547 s] [INFO] Lens CLI ........................................... SUCCESS [03:45 min] [INFO] Lens Examples ...................................... SUCCESS [ 11.595 s] [INFO] Lens Distribution .................................. SUCCESS [ 13.176 s] [INFO] Lens ML Lib ........................................ SUCCESS [02:03 min] [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.752 s] [INFO] Lens Regression .................................... SUCCESS [ 15.811 s] [INFO] Lens UI ............................................ SUCCESS [ 50.811 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 33:53 min [INFO] Finished at: 2015-09-29T22:48:22+05:30 [INFO] Final Memory: 175M/3158M [INFO] ------------------------------------------------------------------------ Thanks, Deepak Barr
