> On Oct. 8, 2015, 3:40 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/LensServerConf.java, lines > > 47-52 > > <https://reviews.apache.org/r/39081/diff/1/?file=1092314#file1092314line47> > > > > Should we convert this part of code into Utility Method(This is > > repeated/ used in two places as of now, here and in LensSessionImpl.java)? > > > > Something like : > > > > public static Configuration getConfWithoutServerProps(Configuration > > base){ > > .... > > }
I agree there is repetation of code, but I feel providing a utility method will make people call this unnecessarily - without intent. Right it is made sure it is called only twice in the lifetime of server. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39081/#review101852 ----------------------------------------------------------- On Oct. 7, 2015, 11:16 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39081/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 11:16 a.m.) > > > Review request for lens. > > > Bugs: LENS-446 > https://issues.apache.org/jira/browse/LENS-446 > > > Repository: lens > > > Description > ------- > > Changes include : > - Removing server configuration properties from session and driver configs > - Updated tests to verify show params and the query configuration - not to > contain the server properties. > > > Diffs > ----- > > lens-server/src/main/java/org/apache/lens/server/LensApplication.java > a446ab6 > lens-server/src/main/java/org/apache/lens/server/LensServerConf.java > 4d333c6 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 73179e1 > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > d0677cc > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > ea75ffb > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 8fffbc9 > > Diff: https://reviews.apache.org/r/39081/diff/ > > > Testing > ------- > > Tested on local cli. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.930s] > [INFO] Lens .............................................. SUCCESS [2.949s] > [INFO] Lens API .......................................... SUCCESS [25.002s] > [INFO] Lens API for server and extensions ................ SUCCESS [22.247s] > [INFO] Lens Cube ......................................... SUCCESS [5:13.181s] > [INFO] Lens DB storage ................................... SUCCESS [20.544s] > [INFO] Lens Query Library ................................ SUCCESS [18.042s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:50.267s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [36.073s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.794s] > [INFO] Lens Server ....................................... SUCCESS [8:21.674s] > [INFO] Lens client ....................................... SUCCESS [37.459s] > [INFO] Lens CLI .......................................... SUCCESS [2:34.216s] > [INFO] Lens Examples ..................................... SUCCESS [10.152s] > [INFO] Lens Distribution ................................. SUCCESS [9.089s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:22.334s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.921s] > [INFO] Lens Regression ................................... SUCCESS [11.227s] > [INFO] Lens UI ........................................... SUCCESS [24.311s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 24:20.336s > [INFO] Finished at: Wed Oct 07 11:07:20 UTC 2015 > [INFO] Final Memory: 195M/2046M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
