----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39311/#review102585 -----------------------------------------------------------
Can we include a unit test also? lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java (line 361) <https://reviews.apache.org/r/39311/#comment160292> Should this be min of both ? - Amareshwari Sriramadasu On Oct. 14, 2015, 8:20 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39311/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2015, 8:20 a.m.) > > > Review request for lens. > > > Bugs: LENS-820 > https://issues.apache.org/jira/browse/LENS-820 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > a6cff417ee88b2ab3799e86d314b56035b7e304c > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > da47fa5cb1fb5fbf6065b45de8e6f413c01bf779 > > Diff: https://reviews.apache.org/r/39311/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
