----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39315/#review102625 -----------------------------------------------------------
Ship it! Ship It! - Rajat Khandelwal On Oct. 14, 2015, 5:41 p.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39315/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2015, 5:41 p.m.) > > > Review request for lens. > > > Bugs: LENS-821 > https://issues.apache.org/jira/browse/LENS-821 > > > Repository: lens > > > Description > ------- > > Cube queries with filters with comma in IN list for eg. column IN > ('test,123', 'test,345') not replacing table alias in fact subquery properly. > > > Diffs > ----- > > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > 295b476 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java > db09a4b > > Diff: https://reviews.apache.org/r/39315/diff/ > > > Testing > ------- > > Added unit test for the fix. mvn clean install is working fine. > > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [19.350s] > [INFO] Lens .............................................. SUCCESS [23.089s] > [INFO] Lens API .......................................... SUCCESS [45.152s] > [INFO] Lens API for server and extensions ................ SUCCESS [42.298s] > [INFO] Lens Cube ......................................... SUCCESS [7:22.998s] > [INFO] Lens DB storage ................................... SUCCESS [33.203s] > [INFO] Lens Query Library ................................ SUCCESS [26.143s] > [INFO] Lens Hive Driver .................................. SUCCESS [4:23.919s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [1:07.686s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [31.795s] > [INFO] Lens Server ....................................... SUCCESS > [19:26.345s] > [INFO] Lens client ....................................... SUCCESS [1:02.367s] > [INFO] Lens CLI .......................................... SUCCESS [8:22.527s] > [INFO] Lens Examples ..................................... SUCCESS [32.166s] > [INFO] Lens Distribution ................................. SUCCESS [32.780s] > [INFO] Lens ML Lib ....................................... SUCCESS [4:02.491s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [13.711s] > [INFO] Lens Regression ................................... SUCCESS [23.502s] > [INFO] Lens UI ........................................... SUCCESS [16.484s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 51:29.337s > [INFO] Finished at: Wed Oct 14 17:41:05 IST 2015 > [INFO] Final Memory: 196M/1665M > > > Thanks, > > Sushil Mohanty > >
