----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39483/#review103379 -----------------------------------------------------------
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java (lines 1028 - 1038) <https://reviews.apache.org/r/39483/#comment161398> Can we make the test case simpler? As in a simpler query can also test the feature added. - Rajat Khandelwal On Oct. 20, 2015, 10:10 p.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39483/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2015, 10:10 p.m.) > > > Review request for lens. > > > Bugs: LENS-838 > https://issues.apache.org/jira/browse/LENS-838 > > > Repository: lens > > > Description > ------- > > Currently literal escape "\'" is not being rewritten properly in fact filter > pushdown subquery. > > > Diffs > ----- > > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > 2d81ff2 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java > 77ab302 > > Diff: https://reviews.apache.org/r/39483/diff/ > > > Testing > ------- > > Added unit test for the same. mvn clean test is running fine. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.214s] > [INFO] Lens .............................................. SUCCESS [3.849s] > [INFO] Lens API .......................................... SUCCESS [23.475s] > [INFO] Lens API for server and extensions ................ SUCCESS [21.289s] > [INFO] Lens Cube ......................................... SUCCESS [5:29.531s] > [INFO] Lens DB storage ................................... SUCCESS [20.594s] > [INFO] Lens Query Library ................................ SUCCESS [18.317s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:55.668s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [39.508s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [20.276s] > [INFO] Lens Server ....................................... SUCCESS [8:16.843s] > [INFO] Lens client ....................................... SUCCESS [38.174s] > [INFO] Lens CLI .......................................... SUCCESS [59.223s] > [INFO] Lens Examples ..................................... SUCCESS [9.262s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.492s] > [INFO] Lens Distribution ................................. SUCCESS [9.412s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:26.900s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.188s] > [INFO] Lens Regression ................................... SUCCESS [14.860s] > [INFO] Lens UI ........................................... SUCCESS [28.267s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 23:23.342s > [INFO] Finished at: Tue Oct 20 16:38:12 UTC 2015 > [INFO] Final Memory: 196M/1690M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sushil Mohanty > >
