-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39598/
-----------------------------------------------------------

(Updated Oct. 23, 2015, 4:15 p.m.)


Review request for lens.


Changes
-------

Renamed the method name.


Bugs: LENS-842
    https://issues.apache.org/jira/browse/LENS-842


Repository: lens


Description
-------

Currently rewritten query for JDBC driver is having backquote in alias name. 
This is not supported by all databases, changing this to double quote which is 
commonly used.


Diffs (updated)
-----

  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 2d81ff2 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
 77ab302 

Diff: https://reviews.apache.org/r/39598/diff/


Testing
-------

Added new unit test. mvn clean install is running fine.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [11.676s]
[INFO] Lens .............................................. SUCCESS [20.239s]
[INFO] Lens API .......................................... SUCCESS [40.179s]
[INFO] Lens API for server and extensions ................ SUCCESS [34.746s]
[INFO] Lens Cube ......................................... SUCCESS [7:55.199s]
[INFO] Lens DB storage ................................... SUCCESS [28.959s]
[INFO] Lens Query Library ................................ SUCCESS [26.757s]
[INFO] Lens Hive Driver .................................. SUCCESS [4:38.749s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [58.672s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [28.183s]
[INFO] Lens Server ....................................... SUCCESS [26:57.251s]
[INFO] Lens client ....................................... SUCCESS [1:01.795s]
[INFO] Lens CLI .......................................... SUCCESS [1:30.578s]
[INFO] Lens Examples ..................................... SUCCESS [15.974s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [5.639s]
[INFO] Lens Distribution ................................. SUCCESS [22.021s]
[INFO] Lens ML Lib ....................................... SUCCESS [3:17.458s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [16.127s]
[INFO] Lens Regression ................................... SUCCESS [28.530s]
[INFO] Lens UI ........................................... SUCCESS [33.597s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 51:33.965s
[INFO] Finished at: Fri Oct 23 20:36:19 IST 2015
[INFO] Final Memory: 185M/1352M
[INFO] ------------------------------------------------------------------------


Thanks,

Sushil Mohanty

Reply via email to