----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39650/#review103997 -----------------------------------------------------------
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java (line 1001) <https://reviews.apache.org/r/39650/#comment162186> How is this joining with AND is working? Can you include tests with some child filters being on OR ? lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java (line 1111) <https://reviews.apache.org/r/39650/#comment162185> Can you add test with only filter being present on fact.time and it is not selected - Amareshwari Sriramadasu On Oct. 26, 2015, 11:22 a.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39650/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2015, 11:22 a.m.) > > > Review request for lens. > > > Bugs: LENS-846 > https://issues.apache.org/jira/browse/LENS-846 > > > Repository: lens > > > Description > ------- > > For optimization all fact filters should be pushed down to fact subquery. > Currently this is not happening. > > > Diffs > ----- > > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > c6797aa > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java > 31c7dad > > Diff: https://reviews.apache.org/r/39650/diff/ > > > Testing > ------- > > JDBC tests are running fine. Will update all test result shortly. > > > Thanks, > > Sushil Mohanty > >
