----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39685/#review104164 -----------------------------------------------------------
Ship it! Ship It! - Rajat Khandelwal On Oct. 27, 2015, 7 p.m., Puneet Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39685/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2015, 7 p.m.) > > > Review request for lens. > > > Bugs: LENS-850 > https://issues.apache.org/jira/browse/LENS-850 > > > Repository: lens > > > Description > ------- > > Changes for **LENS-850** > > -Back quoted column alias in all cases. This is required since some alias > values can match DB keywords(example : year as alias) and in such case > queries can fail on certain DBs if the alias in not back quoted > > -Fixed Test cases where query was being checked for aliases > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 1964e32 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > e6c3be0 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > f5ff49a > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java > b2a15a0 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java > b0b2e88 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java > 7580541 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java > d4d812f > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java > d8c2f63 > > Diff: https://reviews.apache.org/r/39685/diff/ > > > Testing > ------- > > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 4.889 > s] > [INFO] Lens ............................................... SUCCESS [ 4.539 > s] > [INFO] Lens API ........................................... SUCCESS [ 12.173 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 13.739 > s] > [INFO] Lens Cube .......................................... SUCCESS [ 17.653 > s] > [INFO] Lens DB storage .................................... SUCCESS [ 1.731 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 2.545 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [ 3.868 > s] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 5.935 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 3.859 > s] > [INFO] Lens Server ........................................ SUCCESS [ 32.874 > s] > [INFO] Lens client ........................................ SUCCESS [ 3.589 > s] > [INFO] Lens CLI ........................................... SUCCESS [ 6.192 > s] > [INFO] Lens Examples ...................................... SUCCESS [ 1.819 > s] > [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 2.703 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 12.766 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [ 5.735 > s] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 5.241 > s] > [INFO] Lens Regression .................................... SUCCESS [ 5.171 > s] > [INFO] Lens UI ............................................ SUCCESS [ 10.216 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 02:38 min > [INFO] Finished at: 2015-10-27T18:52:05+05:30 > [INFO] Final Memory: 188M/1572M > > > Thanks, > > Puneet Gupta > >
