----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39809/#review104535 -----------------------------------------------------------
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java (line 1336) <https://reviews.apache.org/r/39809/#comment162778> Can you add assert for the storage table being skipped? - Amareshwari Sriramadasu On Oct. 30, 2015, 8:27 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39809/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2015, 8:27 a.m.) > > > Review request for lens. > > > Bugs: LENS-719 > https://issues.apache.org/jira/browse/LENS-719 > > > Repository: lens > > > Description > ------- > > We can specify absolute and relative start time for a fact. This improvement > request is to add the ability to override the start time of a fact on a > storage and a update period. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 2796cd9805e470923164ae3d7a96de7cdc94b920 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 9ea43bba0244555678499799edfba444822b73fd > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > f67fc260bf9b5964189df2a5e083bd40e8f90062 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > dc11b4ce4598bf6d1dc2dc7ad814bd8757ee34fd > > Diff: https://reviews.apache.org/r/39809/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
