-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40537/#review107353
-----------------------------------------------------------



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 (line 269)
<https://reviews.apache.org/r/40537/#comment166456>

    Why is private removed?



lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java (line 129)
<https://reviews.apache.org/r/40537/#comment166458>

    Is getServerConf() same as LensServerConf.getHiveConf() ?



lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java
 (line 76)
<https://reviews.apache.org/r/40537/#comment166461>

    Does it need to extend LensJerseyTest? Seems it is creatin its own drivers, 
should not be.


- Amareshwari Sriramadasu


On Nov. 20, 2015, 11:21 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40537/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 11:21 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-869
>     https://issues.apache.org/jira/browse/LENS-869
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> 
> Diffs
> -----
> 
>   lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 
> 6db720d0f62425454f6a9e18a0365897c08d1980 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  fdc8bfd315e29a3f74232767dc4776f155bb1d22 
>   
> lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java
>  908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b 
>   lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 
> 3dad050e255cbb177a46b6a14f49acf33e9a51bd 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40537/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Reply via email to