> On Nov. 24, 2015, 6:26 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java, > > line 190 > > <https://reviews.apache.org/r/40597/diff/4/?file=1138750#file1138750line190> > > > > Why is this removed?
It had no usages. > On Nov. 24, 2015, 6:26 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java, > > lines 228-231 > > <https://reviews.apache.org/r/40597/diff/4/?file=1138750#file1138750line228> > > > > Why are we creating such a cache? I thought it could probably add to improving performance. Since at any point of time, there will be a few values that will repeatedly be asked for parsing/formatting. And those values will naturally expire as time passes. > On Nov. 24, 2015, 6:26 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java, line 49 > > <https://reviews.apache.org/r/40597/diff/4/?file=1138751#file1138751line49> > > > > Let us move this to test itself. Such cache in main code would give > > wrong time values. Moved to CubeTestSetup. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40597/#review107769 ----------------------------------------------------------- On Nov. 25, 2015, 12:35 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40597/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2015, 12:35 p.m.) > > > Review request for lens. > > > Bugs: LENS-871 > https://issues.apache.org/jira/browse/LENS-871 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 1f13617be4f964c8ed7326f57bd404ee354aa77f > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > e5cf468db36bb9e29d79bd4ca1d11a9f32c74e53 > lens-cube/src/main/java/org/apache/lens/cube/metadata/StorageTableDesc.java > 0a2c5dfdcf819690c7fa7573a955791c84a19d5e > lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java > f192463dc2d32d9a783495ef299869a56281cc15 > lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java > 4690d1d479e78dcd5ec46a009d1d64734c4302e9 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 6b6f645ed9105fa535a63c12abdfa3f80d8a734c > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 999faa07a0ef4cecd7b765156268f0ba7c0d8e60 > lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java > 6dcb2d79420b29fa85bd115f375c0c7e42c50834 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 27f9e0e016db83a38865e8fdb02188b65a0df531 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 5f9f6396954f56fa13914e546ece597c7fdeaa88 > > Diff: https://reviews.apache.org/r/40597/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.814s] > [INFO] Lens .............................................. SUCCESS [2.908s] > [INFO] Lens API .......................................... SUCCESS [26.054s] > [INFO] Lens API for server and extensions ................ SUCCESS [21.785s] > [INFO] Lens Cube ......................................... SUCCESS [5:37.766s] > [INFO] Lens DB storage ................................... SUCCESS [20.543s] > [INFO] Lens Query Library ................................ SUCCESS [17.053s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:49.187s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [36.206s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.148s] > [INFO] Lens Server ....................................... SUCCESS [7:52.960s] > [INFO] Lens client ....................................... SUCCESS [34.571s] > [INFO] Lens CLI .......................................... SUCCESS [52.979s] > [INFO] Lens Examples ..................................... SUCCESS [10.169s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.466s] > [INFO] Lens Distribution ................................. SUCCESS [9.277s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:17.322s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.895s] > [INFO] Lens Regression ................................... SUCCESS [12.466s] > [INFO] Lens UI ........................................... SUCCESS [26.585s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 22:31.093s > [INFO] Finished at: Tue Nov 24 12:37:46 UTC 2015 > [INFO] Final Memory: 194M/1512M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
