> On Nov. 25, 2015, 10:58 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java, > > lines 88-97 > > <https://reviews.apache.org/r/40537/diff/6/?file=1138224#file1138224line88> > > > > Lets have them in TestLensUtil itself instead of LensUtil. > > > > Keeping in general code, will allow use of these methods and i think > > these methods should not be used in non-test code.
`TestLensUtil` contained testcases of `LensUtil`, hence I removed it from there. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40537/#review107917 ----------------------------------------------------------- On Nov. 24, 2015, 12:21 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40537/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 12:21 p.m.) > > > Review request for lens. > > > Bugs: LENS-869 > https://issues.apache.org/jira/browse/LENS-869 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > c96ef200f710076e246f8ac2095f398a5b0da985 > lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java > 6dcb2d79420b29fa85bd115f375c0c7e42c50834 > > lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java > e41f2f447d0d3c9ff49d924456124a7e9e4041b5 > > lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java > a6acb7d3f8b69646d09c8b8e712f44bdf95b3c62 > lens-server/src/main/java/org/apache/lens/server/LensServerConf.java > 6db720d0f62425454f6a9e18a0365897c08d1980 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > fdc8bfd315e29a3f74232767dc4776f155bb1d22 > > lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java > 908b86fa3a2f26ee429cf32ccd6b0dd4b52beb8b > > lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultQueryCollection.java > 844237a25dd4c305698fc650f97ae5004100b9fd > > lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java > ca24a8baa2a61238a26427d52108eed2a710b7d0 > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > 3dad050e255cbb177a46b6a14f49acf33e9a51bd > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java > ec6fd86af51d9fc77dc420a787f4f9e70e2ac625 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > c37b0ed8a0fd44cdd6e52c36bb2e1cec57f09e9a > > Diff: https://reviews.apache.org/r/40537/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.808s] > [INFO] Lens .............................................. SUCCESS [2.938s] > [INFO] Lens API .......................................... SUCCESS [22.467s] > [INFO] Lens API for server and extensions ................ SUCCESS [19.336s] > [INFO] Lens Cube ......................................... SUCCESS [6:05.328s] > [INFO] Lens DB storage ................................... SUCCESS [22.474s] > [INFO] Lens Query Library ................................ SUCCESS [16.592s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:28.038s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [44.440s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [24.834s] > [INFO] Lens Server ....................................... SUCCESS > [10:27.398s] > [INFO] Lens client ....................................... SUCCESS [38.697s] > [INFO] Lens CLI .......................................... SUCCESS [56.005s] > [INFO] Lens Examples ..................................... SUCCESS [9.633s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.521s] > [INFO] Lens Distribution ................................. SUCCESS [9.810s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:26.313s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.131s] > [INFO] Lens Regression ................................... SUCCESS [15.502s] > [INFO] Lens UI ........................................... SUCCESS [32.531s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 26:48.728s > [INFO] Finished at: Mon Nov 23 11:40:27 UTC 2015 > [INFO] Final Memory: 203M/2051M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
