> On Dec. 8, 2015, 9:08 a.m., Puneet Gupta wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java, > > line 48 > > <https://reviews.apache.org/r/41039/diff/1/?file=1155161#file1155161line48> > > > > Shall we make this be a separate constraint and not part of this > > constraint? > > > > MaxConcurrentQueriesPerQueueConstraint will only be used if its > > configured ( say for Hive Driver and not for JDBC)
I did not want to add another confusing classname for users to set in driver properties. One class can handle all 4 combinations of 2 constraints being present/absent. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41039/#review109253 ----------------------------------------------------------- On Dec. 7, 2015, 8:28 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41039/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2015, 8:28 p.m.) > > > Review request for lens. > > > Bugs: LENS-890 > https://issues.apache.org/jira/browse/LENS-890 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java > 38d58c710a2b917c34cda5de96a36dc49b6f15f0 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > 2f20113a1a30f902a1db4b25d5a78da0126a1b0c > > lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java > bae2e6490aafbfd55c9983c94d9cc892af384f7b > > lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java > b6e6c2f1bd2e4f3c0acdcdaae57dcd812e6bb435 > > lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java > 55a2eea110f9001c962faede01cef396e8c91b6c > > lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java > 9138f8ea2bb0b87bfcd2c9a4770bc732856fa680 > > Diff: https://reviews.apache.org/r/41039/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
