> On Dec. 3, 2015, 11:34 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java, line 179 > > <https://reviews.apache.org/r/40899/diff/2/?file=1152902#file1152902line179> > > > > I think we already have error code for parsing, can we use that here? > > Rajat Khandelwal wrote: > We're using SYNTAX_ERROR in other places, used that here too :) > > Amareshwari Sriramadasu wrote: > SYNTAX_ERROR is for query, and expression parsing is for metastore. > Please confirm if my statement is correct. > Shall we create a metastore error code (>3100) and pass it from parseExpr > ? > > Rajat Khandelwal wrote: > parseExpr is used in both `cube.metadata` and `cube.parse` modules. wrong > expressions can also occur while processing a query.
I'm inclined to creating an expression parsing error code instead of syntax error - mainly because hitting expression parsing error during query writing might be unlikely because entity creation itself would fail with that error. The current code throwing exception during query writing would never be hit - if entity creation has failed. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40899/#review108909 ----------------------------------------------------------- On Dec. 4, 2015, 11:39 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40899/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2015, 11:39 a.m.) > > > Review request for lens. > > > Bugs: LENS-851 > https://issues.apache.org/jira/browse/LENS-851 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java > b4185174c7ca7365bf9de7e2a0a0f75bdde6ba4b > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 7f8146158c1e2d883ee9327c4bf847883d0e1004 > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java > 97088a146729d4d2fb6ed6c55c2d16bfa8c75339 > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > 9a9d1348cce1b90fa9d558cc6399d441cca9fca1 > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java > 60b2dde8a7e088d8712879c68cd98193bb72de03 > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java > 418ef5a7b64f717618c3b16fe3755141c07beb76 > lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java > c9ba561bc8da1abb59898619620bbd47ec43028c > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > e415a5adeb5a8af16bad56c96b9f9a32cb7afcbb > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > fea70b72cbde190d69d46f68d163fd9e541c53f8 > > Diff: https://reviews.apache.org/r/40899/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.226s] > [INFO] Lens .............................................. SUCCESS [1.371s] > [INFO] Lens API .......................................... SUCCESS [7.419s] > [INFO] Lens API for server and extensions ................ SUCCESS [9.282s] > [INFO] Lens Cube ......................................... SUCCESS [5:14.939s] > [INFO] Lens DB storage ................................... SUCCESS [11.174s] > [INFO] Lens Query Library ................................ SUCCESS [5.068s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:37.060s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [23.202s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [5.523s] > [INFO] Lens Server ....................................... SUCCESS > [10:04.272s] > [INFO] Lens client ....................................... SUCCESS [23.400s] > [INFO] Lens CLI .......................................... SUCCESS [40.574s] > [INFO] Lens Examples ..................................... SUCCESS [0.455s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.338s] > [INFO] Lens Distribution ................................. SUCCESS [8.315s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:05.857s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.877s] > [INFO] Lens Regression ................................... SUCCESS [2.549s] > [INFO] Lens UI ........................................... SUCCESS [26.262s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 21:52.090s > [INFO] Finished at: Thu Dec 03 08:36:40 UTC 2015 > [INFO] Final Memory: 170M/922M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
