----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41193/#review109919 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java (line 48) <https://reviews.apache.org/r/41193/#comment169608> Can you add comments about what comparision we are doing here? lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java (line 84) <https://reviews.apache.org/r/41193/#comment169609> Can you convert this to a lazy Getter method and use it in below method also ? - Amareshwari Sriramadasu On Dec. 10, 2015, 3:36 p.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41193/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2015, 3:36 p.m.) > > > Review request for lens. > > > Bugs: LENS-270 > https://issues.apache.org/jira/browse/LENS-270 > > > Repository: lens > > > Description > ------- > > After this change NO_CANDIDATE_FACT_AVAILABLE exception throws only brief > error also it compares errors across drivers to show the appropriate one. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > cf114c9 > lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 7a92b3b > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > ee84a4c > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > fea70b7 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > d16ea4c > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java > 1fc8bc8 > > Diff: https://reviews.apache.org/r/41193/diff/ > > > Testing > ------- > > Fixed test cases. mvn clean install is running fine. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.857s] > [INFO] Lens .............................................. SUCCESS [3.609s] > [INFO] Lens API .......................................... SUCCESS [24.695s] > [INFO] Lens API for server and extensions ................ SUCCESS [21.389s] > [INFO] Lens Cube ......................................... SUCCESS > [11:16.979s] > [INFO] Lens DB storage ................................... SUCCESS [20.342s] > [INFO] Lens Query Library ................................ SUCCESS [17.663s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:49.242s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [36.354s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.701s] > [INFO] Lens Server ....................................... SUCCESS [9:46.856s] > [INFO] Lens client ....................................... SUCCESS [32.908s] > [INFO] Lens CLI .......................................... SUCCESS [50.828s] > [INFO] Lens Examples ..................................... SUCCESS [8.110s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.703s] > [INFO] Lens Distribution ................................. SUCCESS [8.565s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:24.915s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.194s] > [INFO] Lens Regression ................................... SUCCESS [13.202s] > [INFO] Lens UI ........................................... SUCCESS [33.676s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 30:10.728s > [INFO] Finished at: Thu Dec 10 06:47:36 UTC 2015 > [INFO] Final Memory: 200M/2134M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sushil Mohanty > >
