> On Dec. 11, 2015, 5:54 a.m., Amareshwari Sriramadasu wrote: > > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, > > line 145 > > <https://reviews.apache.org/r/41035/diff/2/?file=1155098#file1155098line145> > > > > I did not like the fact that we need to put off pretty printing to see > > correct values from json. > > > > Is there a way to fix pretty printing not to eat up values, instead of > > putting it off? > > Rajat Khandelwal wrote: > My thought was that let's not disturb the normal output, experiment with > the new output and when it feels right, switch to that permanently. I was > originally going to change the normal output, but then I decided to go with > this approach. Let me know your thoughts.
Putting off pretty printing as a feature to see actual json values is a nice to have feature. But we need to fix pretty printing not to eat up some characters, independently. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41035/#review109920 ----------------------------------------------------------- On Dec. 7, 2015, 1:27 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41035/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2015, 1:27 p.m.) > > > Review request for lens. > > > Bugs: LENS-791 > https://issues.apache.org/jira/browse/LENS-791 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/LensConf.java > ff965d6aabf052371e0b3b4644a5f60d1210be3d > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java > 643772596c4724253333c0688a93ed621b4dba45 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java > a0c05b41650cd8303879c6c370d892c544adf6ca > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java > 0aa51a8eeea2ad3e0b43d7f011c50b83b0ba30e4 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java > dc8349e322adcb031ef503850e012603f5865088 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > fe9b84dd5574b922c6b8a16a1b8c5b7518aa400a > > lens-cli/src/main/java/org/apache/lens/cli/commands/LogicalTableCrudCommand.java > a04d5c836a31b625e0efcd5509d999d6e483cbb6 > lens-client/src/main/java/org/apache/lens/client/LensClient.java > 5fd04c4591264ac2e5082f1a602877771b15fac9 > > Diff: https://reviews.apache.org/r/41035/diff/ > > > Testing > ------- > > lens-shell>describe dimtable dim_table > > columns : > column : > name : id type : int comment : ID > name : name type : string comment : name > name : detail type : string comment : more details > name : d2id type : int comment : d2 ID > > > properties : > property : > name : cube.table.type value : DIM_TABLE > name : dimtble.dim_table.local.dumpperiod value : HOURLY > name : dim1.prop value : d1 > name : cube.table.dim_table.weight value : 100.0 > name : dimtble.dim_table.storages value : local > name : transient_lastDdlTime value : 1449487545 > name : dimtble.dim_table.dim.name value : sample_dim > > > storageTables : > storageTable : > updatePeriods : updatePeriod : HOURLY > storageName : local tableDesc : partCols : column : > name : dt type : string comment : Time column > tableParameters : property : > name : EXTERNAL value : TRUE name : cube.storagetable.time.partcols > value : dt name : transient_lastDdlTime value : 1449487545 > serdeParameters : property : > name : serialization.format value : name : field.delim value : > timePartCols : dt > external : true tableLocation : file:/tmp/examples/dim1 inputFormat : > org.apache.hadoop.mapred.TextInputFormat outputFormat : > org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat fieldDelimiter : > serdeClassName : org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe > storageHandlerName : numBuckets : 0 compressed : false > > > dimensionName : sample_dim > tableName : dim_table > weight : 100.0 > > lens-shell>set lens.cli.json.pretty=true > Client side Set lens.cli.json.pretty=true > lens-shell>describe dimtable dim_table > { > "columns" : { > "column" : [ { "name" : "id", "type" : "int", "comment" : "ID" > }, { "name" : "name", "type" : "string", "comment" : "name" > }, { "name" : "detail", "type" : "string", "comment" : "more details" > }, { "name" : "d2id", "type" : "int", "comment" : "d2 ID" > } ] > }, > "properties" : { > "property" : [ { "name" : "cube.table.type", "value" : "DIM_TABLE" > }, { "name" : "dimtble.dim_table.local.dumpperiod", "value" : "HOURLY" > }, { "name" : "dim1.prop", "value" : "d1" > }, { "name" : "cube.table.dim_table.weight", "value" : "100.0" > }, { "name" : "dimtble.dim_table.storages", "value" : "local" > }, { "name" : "transient_lastDdlTime", "value" : "1449487545" > }, { "name" : "dimtble.dim_table.dim.name", "value" : "sample_dim" > } ] > }, > "storageTables" : { > "storageTable" : [ { "updatePeriods" : { "updatePeriod" : [ "HOURLY" ] }, > "storageName" : "local", "tableDesc" : { "partCols" : { "column" : [ { > "name" : "dt", "type" : "string", "comment" : "Time column" } ] }, > "tableParameters" : { "property" : [ { "name" : "EXTERNAL", "value" : > "TRUE" }, { "name" : "cube.storagetable.time.partcols", "value" : "dt" }, > { "name" : "transient_lastDdlTime", "value" : "1449487545" } ] }, > "serdeParameters" : { "property" : [ { "name" : "serialization.format", > "value" : "," }, { "name" : "field.delim", "value" : "," } ] }, > "timePartCols" : [ "dt" ], "external" : true, "tableLocation" : > "file:/tmp/examples/dim1", "inputFormat" : > "org.apache.hadoop.mapred.TextInputFormat", "outputFormat" : > "org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat", > "fieldDelimiter" : ",", "serdeClassName" : > "org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe", "storageHandlerName" : > "", "numBuckets" : 0, "compressed" : false } > } ] > }, > "dimensionName" : "sample_dim", > "tableName" : "dim_table", > "weight" : 100.0 > } > > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 4.771 > s] > [INFO] Lens ............................................... SUCCESS [ 7.473 > s] > [INFO] Lens API ........................................... SUCCESS [ 40.329 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 36.626 > s] > [INFO] Lens Cube .......................................... SUCCESS [01:14 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 16.892 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 20.927 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [ 24.685 > s] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 32.979 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 23.645 > s] > [INFO] Lens Server ........................................ SUCCESS [01:24 > min] > [INFO] Lens client ........................................ SUCCESS [ 28.851 > s] > [INFO] Lens CLI ........................................... SUCCESS [ 26.117 > s] > [INFO] Lens Examples ...................................... SUCCESS [ 19.180 > s] > [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.428 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 14.176 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [ 42.655 > s] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 5.132 > s] > [INFO] Lens Regression .................................... SUCCESS [ 25.698 > s] > [INFO] Lens UI ............................................ SUCCESS [ 8.245 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 09:01 min > [INFO] Finished at: 2015-12-07T18:55:35+05:30 > [INFO] Final Memory: 194M/1746M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
