> On Dec. 16, 2015, 6:38 a.m., Amareshwari Sriramadasu wrote: > > lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java, > > lines 81-83 > > <https://reviews.apache.org/r/41437/diff/1/?file=1165787#file1165787line81> > > > > Can we put the commented asserts back? > > piyush mukati wrote: > For this test, we have to uncomment below code in JDBCUtils.java > / * if (jdbcUri.getHost() != null) { params.setHost(jdbcUri.getHost()); } > if (jdbcUri.getPort() > 0) { * params.setPort(jdbcUri.getPort()); } / > > I was not sure why it was commented erliar, so i didnt change. > > Amareshwari Sriramadasu wrote: > If you see there is no issue with the code, go ahead and uncomment.
Above portion was commented because now LensClientConfig does not have host or port in configuration. it has only SERVER_BASE_URL. host and port are derived from base url. - piyush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41437/#review110628 ----------------------------------------------------------- On Dec. 18, 2015, 6:13 a.m., piyush mukati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41437/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2015, 6:13 a.m.) > > > Review request for lens. > > > Bugs: LENS-896 > https://issues.apache.org/jira/browse/LENS-896 > > > Repository: lens > > > Description > ------- > > fix for setting base url. Inside method JDBCUtils.parseUrl > > > Diffs > ----- > > lens-client/src/main/java/org/apache/lens/client/jdbc/JDBCUtils.java > 34448d3 > lens-client/src/test/java/org/apache/lens/jdbc/JDBCUrlParserTest.java > 3c97878 > > Diff: https://reviews.apache.org/r/41437/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.959 > s] > [INFO] Lens ............................................... SUCCESS [ 6.401 > s] > [INFO] Lens API ........................................... SUCCESS [ 24.920 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 22.679 > s] > [INFO] Lens Cube .......................................... SUCCESS [09:05 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 15.916 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 12.904 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:44 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 31.950 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 14.224 > s] > [INFO] Lens Server ........................................ SUCCESS [15:12 > min] > [INFO] Lens client ........................................ SUCCESS [ 40.419 > s] > [INFO] Lens CLI ........................................... SUCCESS [01:02 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 9.399 > s] > [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 1.154 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 12.348 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [02:20 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.759 > s] > [INFO] Lens Regression .................................... SUCCESS [ 19.590 > s] > [INFO] Lens UI ............................................ SUCCESS [ 5.102 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 34:12 min > [INFO] Finished at: 2015-12-15T17:28:09+05:30 > [INFO] Final Memory: 130M/844M > > > Thanks, > > piyush mukati > >
