----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41794/#review112495 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java (line 55) <https://reviews.apache.org/r/41794/#comment172946> What does false mean here ? lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java (line 527) <https://reviews.apache.org/r/41794/#comment172950> See if we can add check KW_LOCAL for adding local here. lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java (line 89) <https://reviews.apache.org/r/41794/#comment172951> RetryingThriftClient should be available in Hive with HIVE-11482. lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java (line 139) <https://reviews.apache.org/r/41794/#comment172952> change the comment accordingly. lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java (line 381) <https://reviews.apache.org/r/41794/#comment172953> whats the behavior is restoreSession is removed ? pom.xml (line 849) <https://reviews.apache.org/r/41794/#comment172945> Move the version number to a property. - Amareshwari Sriramadasu On Dec. 31, 2015, 8:33 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41794/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2015, 8:33 a.m.) > > > Review request for lens. > > > Bugs: LENS-518 > https://issues.apache.org/jira/browse/LENS-518 > > > Repository: lens > > > Description > ------- > > Creating wish for moving to Apache hive dependency instead of forked hive > dependency. We will create follow up issues in lens and hive make them link > here. > > > Diffs > ----- > > lens-api/pom.xml 8aa2f67a92d22cc6a807b44bdc7e451d09959768 > lens-cli/pom.xml 90824179e231d9cd82d8c3a067ea1815d9f3ff56 > lens-client/pom.xml 5f2f3a983cca87c8c8055f245cde6295f56381b3 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > e7550ca2c8307cba086e848e8b476a670366f7a5 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 1fd1d17bbc05b2ca07d88237b4143ea3cd904d0e > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java > ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > 6c3d4c3b0235f88c16aad148cbbbc30eca89eb7f > lens-driver-es/pom.xml 5705cd2c291e2c0e4879bc8acc390f150881520e > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > c7ef8f124807be41ad9b36629d66ee8f16bbefb3 > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java > f8abd782518cb08ed1607970f4c1fb4075ca4263 > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java > 741294cac27f610b94099c24d59adaa791776487 > lens-driver-jdbc/pom.xml f84513bb7641629b2758245f75a52a3ff1032185 > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > 561452747da67feeab1f08fddbc8615324d2737f > lens-examples/pom.xml 0a5a744d1e376c22914c6fe73e80f9c069ed5ee6 > lens-query-lib/pom.xml 2eec781034a8830aaf2c846dab899ac8fd8d22a2 > lens-server-api/pom.xml d836c162c9920e8608d60600427506a0d75f08e3 > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java > 81160f5b84e1b17a459681f82aa5cc9ba5714db0 > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > 0821fe7bb12e3628f3a800059e0c3e813baca6d7 > lens-server/src/main/java/org/apache/lens/server/LensServices.java > 48b3e002a75b8ea54c9b8672d50bfc8af25f7483 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > cf49a136a5b540c515c5be6f976b1c21733b6b06 > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 817c84c665c59bf8c7a75fd9c12355bfc1109663 > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java > abec2b338e0da6b56934a02d16c48a6a7917845a > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > cc62d92347c9308e80046e83125e3eb823c3cc6c > lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java > 7e0758975cc4d991c24a1df963095d38189f5622 > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java > 5feab715b9a283e0951570a407b464b3bd7007a6 > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java > dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484 > pom.xml 746204e87d046454fbd0e3f4690e3b220487418c > > Diff: https://reviews.apache.org/r/41794/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
