[
https://issues.apache.org/jira/browse/LENS-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091620#comment-15091620
]
Hudson commented on LENS-735:
-----------------------------
UNSTABLE: Integrated in Lens-Commit-Java8 #81 (See
[https://builds.apache.org/job/Lens-Commit-Java8/81/])
LENS-735 : Remove accepting TableReferences for ReferenceDimAttribute
(rajatgupta59: rev 908530f5883ae8844c6a16cb5564c926cc10bf19)
* lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java
* lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeDimensionTable.java
* lens-api/src/main/resources/lens-errors.conf
* lens-examples/src/main/resources/dimension-queries.sql
* lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java
*
lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java
* lens-cube/src/main/java/org/apache/lens/cube/metadata/join/JoinPath.java
* lens-api/src/main/resources/cube-0.1.xsd
* lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/JoinClause.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java
* lens-examples/src/main/resources/sales-cube.xml
* lens-cube/src/main/java/org/apache/lens/cube/metadata/Dimension.java
* lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java
*
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/JoinTree.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinTree.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
* lens-examples/src/main/resources/sample-db-only-dimension.xml
* lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java
* lens-cli/src/test/resources/cube_with_no_weight_facts.xml
* lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinUtils.java
*
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
* lens-examples/src/main/resources/sample-dimension.xml
* lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeColumn.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java
* lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java
* lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java
* lens-cli/src/test/resources/sample-cube.xml
* lens-cli/src/test/resources/test-dimension.xml
*
lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAttribute.java
*
lens-cube/src/main/java/org/apache/lens/cube/metadata/join/TableRelationship.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java
* lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java
* lens-storage-db/src/test/java/org/apache/lens/storage/db/TestDBStorage.java
*
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java
* lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java
*
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
* lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionContext.java
* lens-examples/src/main/resources/sample-cube.xml
*
lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java
* lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractBaseTable.java
* lens-examples/src/main/resources/cube-queries.sql
*
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
* lens-examples/src/main/resources/customer.xml
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateDim.java
* lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java
* lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java
> Remove accepting TableReferences for ReferenceDimAttribute
> ----------------------------------------------------------
>
> Key: LENS-735
> URL: https://issues.apache.org/jira/browse/LENS-735
> Project: Apache Lens
> Issue Type: Improvement
> Components: api, cube
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Labels: incompatible
> Fix For: 2.5
>
> Attachments: LENS-735.8.patch, LENS-735.9.patch
>
>
> We have JoinChains that can be defined for reference dim attribute. Having
> both TableReferences and JoinChains is confusing for user. We should remove
> support for table references and only allow reference dim-attribute to be
> defined as chained column.
> This will simplify the spec to user and also remove a lot of code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
