----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42131/#review113749 -----------------------------------------------------------
Ship it! lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java (lines 357 - 361) <https://reviews.apache.org/r/42131/#comment174558> Is there a need to create an `Collection<Aliased<Dimension>>` when in the iteration we're only concerned about `Dimension`? Instead we can iterate on the original `Set` and create `Aliased` objects inside the loop as and when required. lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java (line 451) <https://reviews.apache.org/r/42131/#comment174559> should we change to debug log? - Rajat Khandelwal On Jan. 11, 2016, 5:37 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42131/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2016, 5:37 p.m.) > > > Review request for lens. > > > Bugs: LENS-917 > https://issues.apache.org/jira/browse/LENS-917 > > > Repository: lens > > > Description > ------- > > The fix is to change the maps joinPathFromColumns, joinPathToColumns and > optionalDimensionMap to used Aliased<Dimension> as the key. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/Aliased.java 56fe9fc > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 38ff5a4 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 06c2a0b > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 26514d8 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > de5f95e > > lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java > 993955a > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 4366938 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > a8390ef > > Diff: https://reviews.apache.org/r/42131/diff/ > > > Testing > ------- > > Added unit test. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.871s] > [INFO] Lens .............................................. SUCCESS [3.451s] > [INFO] Lens API .......................................... SUCCESS [23.610s] > [INFO] Lens API for server and extensions ................ SUCCESS [22.303s] > [INFO] Lens Cube ......................................... SUCCESS > [11:16.518s] > [INFO] Lens DB storage ................................... SUCCESS [19.788s] > [INFO] Lens Query Library ................................ SUCCESS [16.116s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:50.977s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [35.974s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.686s] > [INFO] Lens Server ....................................... SUCCESS > [10:02.838s] > [INFO] Lens client ....................................... SUCCESS [35.386s] > [INFO] Lens CLI .......................................... SUCCESS [53.419s] > [INFO] Lens Examples ..................................... SUCCESS [8.644s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.745s] > [INFO] Lens Distribution ................................. SUCCESS [8.736s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:19.944s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.856s] > [INFO] Lens Regression ................................... SUCCESS [12.626s] > [INFO] Lens UI ........................................... SUCCESS [28.360s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 30:19.801s > [INFO] Finished at: Mon Jan 11 05:25:54 UTC 2016 > [INFO] Final Memory: 217M/2385M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
