----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40579/#review113951 -----------------------------------------------------------
lens-ml-api/src/main/java/org/apache/lens/ml/algo/api/MLAlgo.java (line 52) <https://reviews.apache.org/r/40579/#comment174732> MLModel is a generic class. You can consider adding the generic type to MLAlgo too. lens-ml-api/src/main/java/org/apache/lens/ml/api/LensML.java (line 59) <https://reviews.apache.org/r/40579/#comment174733> Don't drop the generic parameter here. - Rajat Khandelwal On Jan. 11, 2016, 5:02 p.m., vikas singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40579/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2016, 5:02 p.m.) > > > Review request for lens, Amareshwari Sriramadasu, Amruth Sampath, Deepak > Barr, Pranav Agarwal, and sharad agarwal. > > > Repository: lens > > > Description > ------- > > Introduction Of Lens-spark-context package. It is an interface for using > lens's query and ml abilities throught Spark. This patch is against master > branch(instead of LENS-581). > > For running with spark - > ./spark-shell --packages > org.apache.lens:lens-spark-context:2.5.0-beta-SNAPSHOT > import org.apache.lens.client.LensContext; > val lc = new LensContext(sc, "user.name"); > > Common usage is included in README file in the package. > > > Diffs > ----- > > README PRE-CREATION > lens-ml-api/pom.xml PRE-CREATION > lens-ml-api/src/main/java/org/apache/lens/ml/algo/api/AlgoParam.java > PRE-CREATION > lens-ml-api/src/main/java/org/apache/lens/ml/algo/api/Algorithm.java > PRE-CREATION > lens-ml-api/src/main/java/org/apache/lens/ml/algo/api/MLAlgo.java > PRE-CREATION > lens-ml-api/src/main/java/org/apache/lens/ml/algo/api/MLDriver.java > PRE-CREATION > lens-ml-api/src/main/java/org/apache/lens/ml/algo/api/MLModel.java > PRE-CREATION > lens-ml-api/src/main/java/org/apache/lens/ml/api/LensML.java PRE-CREATION > lens-ml-api/src/main/java/org/apache/lens/ml/api/MLTestReport.java > PRE-CREATION > lens-ml-api/src/main/java/org/apache/lens/ml/api/ModelMetadata.java > PRE-CREATION > lens-ml-api/src/main/java/org/apache/lens/ml/api/TestReport.java > PRE-CREATION > lens-ml-dist/src/main/assembly/ml-dist.xml 50c7375 > lens-ml-lib/pom.xml 67215e1 > lens-ml-lib/src/main/java/org/apache/lens/ml/algo/api/AlgoParam.java > e0d13c0 > lens-ml-lib/src/main/java/org/apache/lens/ml/algo/api/Algorithm.java > 29bde29 > lens-ml-lib/src/main/java/org/apache/lens/ml/algo/api/MLAlgo.java 65373c6 > lens-ml-lib/src/main/java/org/apache/lens/ml/algo/api/MLDriver.java d2a2748 > lens-ml-lib/src/main/java/org/apache/lens/ml/algo/api/MLModel.java 73717ac > lens-ml-lib/src/main/java/org/apache/lens/ml/api/LensML.java 23b5437 > lens-ml-lib/src/main/java/org/apache/lens/ml/api/MLTestReport.java 965161a > lens-ml-lib/src/main/java/org/apache/lens/ml/api/ModelMetadata.java 3f7dff1 > lens-ml-lib/src/main/java/org/apache/lens/ml/api/TestReport.java 294fef3 > lens-spark-context/README PRE-CREATION > lens-spark-context/pom.xml PRE-CREATION > > lens-spark-context/src/main/java/org/apache/lens/client/ClassLoaderManager.java > PRE-CREATION > lens-spark-context/src/main/java/org/apache/lens/client/LensContext.java > PRE-CREATION > > lens-spark-context/src/main/java/org/apache/lens/client/ParentClassLoader.java > PRE-CREATION > > lens-spark-context/src/main/java/org/apache/lens/spark/LensSparkConstants.java > PRE-CREATION > > lens-spark-context/src/main/java/org/apache/lens/spark/LensSparkContext.java > PRE-CREATION > > lens-spark-context/src/main/java/org/apache/lens/spark/LensSparkContextConfig.java > PRE-CREATION > > lens-spark-context/src/main/java/org/apache/lens/spark/serde/AbstractSerde.java > PRE-CREATION > lens-spark-context/src/main/java/org/apache/lens/spark/serde/CSVSerde.java > PRE-CREATION > lens-spark-context/src/main/java/org/apache/lens/spark/serde/JSONSerde.java > PRE-CREATION > lens-spark-context/src/main/java/org/apache/lens/spark/serde/Serde.java > PRE-CREATION > > lens-spark-context/src/main/java/org/apache/lens/spark/util/HttpDownloadUtility.java > PRE-CREATION > lens-spark-context/src/main/java/org/apache/lens/spark/util/ScalaUtils.java > PRE-CREATION > lens-spark-context/src/main/java/org/apache/lens/spark/util/Utils.java > PRE-CREATION > > lens-spark-context/src/main/resources/META-INF/services/javax.ws.rs.client.ClientBuilder > PRE-CREATION > > lens-spark-context/src/main/resources/META-INF/services/javax.ws.rs.ext.MessageBodyReader > PRE-CREATION > > lens-spark-context/src/main/resources/META-INF/services/javax.ws.rs.ext.MessageBodyWriter > PRE-CREATION > > lens-spark-context/src/main/resources/META-INF/services/javax.ws.rs.ext.RuntimeDelegate > PRE-CREATION > lens-spark-context/src/main/resources/lens-spark-context-defaults.xml > PRE-CREATION > pom.xml 9b417d9 > > Diff: https://reviews.apache.org/r/40579/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > vikas singh > >
