[ 
https://issues.apache.org/jira/browse/LENS-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093488#comment-15093488
 ] 

Rajat Khandelwal commented on LENS-912:
---------------------------------------

The current way of detecting a cube query in lens is the presence of cube 
keyword at the beginning of the query. The proposed feature is to detect cube 
queries by two methods:

* Either it starts with cube keyword
* Or the table in the from clause is either a dimension or a cube. 

h4. Pros

* Current sql used in LENS is not SQL compliant. Making cube keyword optional 
would be a first step towards becoming SQL compliant. 
* For parsing queries, we use HiveParser 0.13-inm. When we move to Hive master 
from Hive 0.13-inm, queries starting with cube keyword won't be parsable. So we 
need to have another way of detecting cube queries. 

h4. Cons

* Though removing cube keyword can cause confusion for the users, since the 
person reading/writing the query needs to put conscious effort in double 
checking cube/dimension name.


h4. Proposal: 

Change our detection of cube queries to be solely based on cube/dimension 
names. Keep cube keyword optional from the outside, once accepted by lens, lens 
will drop the cube keyword before attempting to parse it. 




> Make `cube` keyword optional in queries
> ---------------------------------------
>
>                 Key: LENS-912
>                 URL: https://issues.apache.org/jira/browse/LENS-912
>             Project: Apache Lens
>          Issue Type: Improvement
>            Reporter: Rajat Khandelwal
>            Assignee: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to