----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42291/#review115430 -----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 197) <https://reviews.apache.org/r/42291/#comment176424> Can you make it **protected**? lens-cli/src/main/java/org/apache/lens/cli/commands/LensLogResourceCommands.java (line 52) <https://reviews.apache.org/r/42291/#comment176426> This command is not only used for fetching query logs. It can be used for fetching other logs like server logs or logs under logs.dir system property etc.... IMO, we should not simply assume user is querying for query logs when this option is absent. - Raju Bairishetti On Jan. 18, 2016, 6:09 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42291/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 6:09 a.m.) > > > Review request for lens. > > > Bugs: LENS-923 > https://issues.apache.org/jira/browse/LENS-923 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java > 643772596c4724253333c0688a93ed621b4dba45 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensLogResourceCommands.java > 59b7355e832eac66b7054bcb33a3ec7e6dfb78ba > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > a29600d25d89e73f26102ba609e04b73f4cb7c58 > src/site/apt/user/cli.apt 65380e680f1370820cf361457ad5286e6e95fd39 > > Diff: https://reviews.apache.org/r/42291/diff/ > > > Testing > ------- > > ``` > $ bin/lens-cli.sh > ======================================= > * * > * Lens Client * > * * > ======================================= > > Welcome to Lens Client > lens-shell>select sample_dim_chain.name, measure2 from sample_cube where > time_range_in(dt, '2014-06-25-00', '2014-06-26-00') and sample_dim_chain.name > != "first" order by sample_dim_chain.name desc limit 2 > 14 Jan 2016 07:44:41 [Spring Shell] INFO cliLogger - Query handle: > f255a717-2dfb-42fe-9a80-8308efae054c > 14 Jan 2016 07:44:46 [Spring Shell] INFO cliLogger - User query: 'select > sample_dim_chain.name, measure2 from sample_cube where time_range_in(dt, > '2014-06-25-00', '2014-06-26-00') and sample_dim_chain.name != "first" order > by sample_dim_chain.name desc limit 2' was submitted to hive/hive1 > 14 Jan 2016 07:44:46 [Spring Shell] INFO cliLogger - Driver query: 'INSERT > OVERWRITE DIRECTORY > "file:/tmp/lensreports/hdfsout/f255a717-2dfb-42fe-9a80-8308efae054c" SELECT > ( sample_dim_chain . name ), sum(( sample_cube . measure2 )) FROM local_fact2 > sample_cube join local_dim_table sample_dim_chain on sample_cube.dim3 = > sample_dim_chain.id and (sample_dim_chain.dt = 'latest') WHERE ((((( > sample_cube . dt ) = '2014-06-25' ) and (( sample_dim_chain . name ) != > "first" )))) GROUP BY ( sample_dim_chain . name ) ORDER BY sample_dim_chain > . name desc LIMIT 2 ' and Driver handle: OperationHandle > [opType=EXECUTE_STATEMENT, > getHandleIdentifier()=75a2615a-8cac-45b3-b070-e284d415a8b4] > 14 Jan 2016 07:44:56 [Spring Shell] INFO cliLogger - Query Status: Status : > RUNNING > Message : Query is running in HiveServer! > Progress : 0.5 > Progress Message : > [{"taskId":"Stage-6","type":"MAPREDLOCAL","externalHandle":"Stage-6","taskState":"FINISHED_STATE"},{"taskId":"Stage-2","type":"MAPRED","externalHandle":null,"taskState":"FINISHED_STATE"},{"taskId":"Stage-3","type":"MAPRED","externalHandle":null,"taskState":"RUNNING_STATE"},{"taskId":"Stage-0","type":"MOVE","externalHandle":"Stage-0","taskState":"UNKNOWN_STATE"}] > > 14 Jan 2016 07:44:58 [Spring Shell] INFO cliLogger - Query Status: Status : > SUCCESSFUL > Message : Query is successful! > Progress : 1.0 > Result Available > sample_dim_chain.name _c1 > Results of query stored at : > file:/tmp/lensreports/hdfsout/f255a717-2dfb-42fe-9a80-8308efae054c processed > in (17) seconds. > > lens-shell>cube select sample_dim_chain.name, measure2 from sample_cube where > time_range_in(dt, '2014-06-25-00', '2014-06-26-00') and sample_dim_chain.name > != "first" order by sample_dim_chain.name desc limit 2 > 14 Jan 2016 07:44:58 [Spring Shell] INFO cliLogger - Query handle: > 894c458c-1555-4690-b2b0-ca3fc10b2eb8 > 14 Jan 2016 07:45:04 [Spring Shell] INFO cliLogger - User query: 'cube > select sample_dim_chain.name, measure2 from sample_cube where > time_range_in(dt, '2014-06-25-00', '2014-06-26-00') and sample_dim_chain.name > != "first" order by sample_dim_chain.name desc limit 2' was submitted to > hive/hive1 > 14 Jan 2016 07:45:04 [Spring Shell] INFO cliLogger - Driver query: 'INSERT > OVERWRITE DIRECTORY > "file:/tmp/lensreports/hdfsout/894c458c-1555-4690-b2b0-ca3fc10b2eb8" SELECT > ( sample_dim_chain . name ), sum(( sample_cube . measure2 )) FROM local_fact2 > sample_cube join local_dim_table sample_dim_chain on sample_cube.dim3 = > sample_dim_chain.id and (sample_dim_chain.dt = 'latest') WHERE ((((( > sample_cube . dt ) = '2014-06-25' ) and (( sample_dim_chain . name ) != > "first" )))) GROUP BY ( sample_dim_chain . name ) ORDER BY sample_dim_chain > . name desc LIMIT 2 ' and Driver handle: OperationHandle > [opType=EXECUTE_STATEMENT, > getHandleIdentifier()=cfe47ca3-32fe-44c8-999a-138943150dee] > 14 Jan 2016 07:45:14 [Spring Shell] INFO cliLogger - Query Status: Status : > RUNNING > Message : Query is running in HiveServer! > Progress : 0.5 > Progress Message : > [{"taskId":"Stage-6","type":"MAPREDLOCAL","externalHandle":"Stage-6","taskState":"FINISHED_STATE"},{"taskId":"Stage-2","type":"MAPRED","externalHandle":null,"taskState":"FINISHED_STATE"},{"taskId":"Stage-3","type":"MAPRED","externalHandle":null,"taskState":"RUNNING_STATE"},{"taskId":"Stage-0","type":"MOVE","externalHandle":"Stage-0","taskState":"UNKNOWN_STATE"}] > > 14 Jan 2016 07:45:14 [Spring Shell] INFO cliLogger - Query Status: Status : > SUCCESSFUL > Message : Query is successful! > Progress : 1.0 > Result Available > sample_dim_chain.name _c1 > Results of query stored at : > file:/tmp/lensreports/hdfsout/894c458c-1555-4690-b2b0-ca3fc10b2eb8 processed > in (15) seconds. > > lens-shell>select --query > > required --query: <query-string>; no default value > lens-shell>cube select sample_dim_chain.name, measure2 from sample_cube where > time_range_in(dt, '2014-06-25-00', '2014-06-26-00') and sample_dim_chain.name > != "first" order by sample_dim_chain.name desc limit 2 --async > 918534fb-3eff-42da-a1dd-25f43a78d377 > lens-shell>cube select sample_dim_chain.name, measure2 from sample_cube where > time_range_in(dt, '2014-06-25-00', '2014-06-26-00') and sample_dim_chain.name > != "first" order by sample_dim_chain.name desc limit 2 --async -0n > > optional --async: <async>; default if option present: 'true'; default if > option not present: 'false' > lens-shell>cube select sample_dim_chain.name, measure2 from sample_cube where > time_range_in(dt, '2014-06-25-00', '2014-06-26-00') and sample_dim_chain.name > != "first" order by sample_dim_chain.name desc limit 2 --async --name > > optional --name: <query-name>; no default value > lens-shell>cube select sample_dim_chain.name, measure2 from sample_cube where > time_range_in(dt, '2014-06-25-00', '2014-06-26-00') and sample_dim_chain.name > != "first" order by sample_dim_chain.name desc limit 2 --async --name myquery > 7009e162-f448-40a6-b297-004499eb8b83 > lens-shell> > ``` > > > Thanks, > > Rajat Khandelwal > >
